Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor on ACL #4640

Merged
merged 3 commits into from
Apr 8, 2024
Merged

refactor on ACL #4640

merged 3 commits into from
Apr 8, 2024

Conversation

davies
Copy link
Contributor

@davies davies commented Apr 3, 2024

No description provided.

@davies davies requested a review from jiefenghuang April 3, 2024 07:10
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 55.95238% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 45.94%. Comparing base (0cf6a43) to head (bcfb97a).
Report is 9 commits behind head on main.

❗ Current head bcfb97a differs from pull request most recent head a6c8d18. Consider uploading reports for the commit a6c8d18 to get more accurate results

Files Patch % Lines
pkg/meta/sql.go 60.52% 10 Missing and 5 partials ⚠️
pkg/meta/redis.go 35.71% 6 Missing and 3 partials ⚠️
pkg/meta/base.go 36.36% 4 Missing and 3 partials ⚠️
pkg/meta/tkv.go 57.14% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4640      +/-   ##
==========================================
- Coverage   45.97%   45.94%   -0.03%     
==========================================
  Files         159      159              
  Lines       42660    42560     -100     
==========================================
- Hits        19611    19553      -58     
+ Misses      20670    20641      -29     
+ Partials     2379     2366      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/meta/sql.go Outdated Show resolved Hide resolved
@davies davies merged commit 732b7a5 into main Apr 8, 2024
32 checks passed
@davies davies deleted the review_acl branch April 8, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants