Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object/ceph: set default path for admin socket and log file #4608

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Mar 28, 2024

Limitations:

  1. Values in both ceph.conf and cluster internal configurations (ceph config) will be overwritten. To adjust these options we have to set the corresponding envs
  2. Only ONE active client can have the admin socket enabled. A pid field may be added into the path later if the connection can be closed gracefully.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.51%. Comparing base (7d8c36e) to head (374d8c3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4608      +/-   ##
==========================================
- Coverage   55.52%   55.51%   -0.01%     
==========================================
  Files         159      159              
  Lines       42984    42984              
==========================================
- Hits        23866    23862       -4     
- Misses      16459    16460       +1     
- Partials     2659     2662       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davies davies merged commit 307870c into main Mar 29, 2024
35 checks passed
@davies davies deleted the ceph-log branch March 29, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants