Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable md5 and crc verification when s3 compatible storage does not support them #4606

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

polyrabbit
Copy link
Contributor

Add option to disable md5 and crc verification when s3 compatible storage does not support them, which improves throughput by 20% and cut cpu usage by 70%

image

…rage does not support them, which improves throughput by 20% and cut cpu usage by 70%
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 54.66%. Comparing base (688dbae) to head (6af0aac).

Files Patch % Lines
pkg/object/s3.go 25.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4606      +/-   ##
==========================================
- Coverage   55.55%   54.66%   -0.89%     
==========================================
  Files         159      159              
  Lines       42972    42984      +12     
==========================================
- Hits        23871    23498     -373     
- Misses      16440    16807     +367     
- Partials     2661     2679      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davies davies merged commit 7d8c36e into juicedata:main Mar 28, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants