Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: force compaction when there's too many slices in one chunk #4573

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Mar 25, 2024

fix #4536

Known limits for value:

  • MySQL: 64 KiB
  • FoundationDB: 100 KB
  • etcd: 1MiB

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 88.31169% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 55.59%. Comparing base (46090dd) to head (808c428).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/meta/redis.go 76.00% 4 Missing and 2 partials ⚠️
pkg/meta/sql.go 88.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4573      +/-   ##
==========================================
- Coverage   55.66%   55.59%   -0.08%     
==========================================
  Files         158      158              
  Lines       43067    43101      +34     
==========================================
- Hits        23973    23961      -12     
- Misses      16430    16468      +38     
- Partials     2664     2672       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/meta/tkv.go Outdated Show resolved Hide resolved
@davies
Copy link
Contributor

davies commented Mar 26, 2024

we can add a unit test to write 10000 times

@SandyXSD
Copy link
Contributor Author

The etcd is misconfigured in the CI, leading to test failure whenever it runs longer than 1 minute (caused by AutoSyncInterval: time.Minute).

@SandyXSD SandyXSD requested a review from davies March 26, 2024 08:03
@davies davies merged commit 11d436e into main Mar 26, 2024
32 checks passed
@davies davies deleted the force-compaction branch March 26, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FoundationDB error code 2103 (Value length exceeds limit)
2 participants