cmd: support human friendly values for bandwidth options #4567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4567 +/- ##
==========================================
- Coverage 55.67% 55.62% -0.06%
==========================================
Files 157 158 +1
Lines 43021 43060 +39
==========================================
Hits 23950 23950
- Misses 16410 16448 +38
- Partials 2661 2662 +1 ☔ View full report in Codecov by Sentry. |
|
@davies Please review each commit individually. |
davies
reviewed
Mar 24, 2024
pkg/sync/sync.go
Outdated
| @@ -1212,7 +1212,7 @@ func Sync(src, dst object.ObjectStorage, config *Config) error { | |||
| wg := sync.WaitGroup{} | |||
| concurrent = make(chan int, config.Threads) | |||
| if config.BWLimit > 0 { | |||
| bps := float64(int64(config.BWLimit)*(1<<20)/8) * 0.85 // 15% overhead | |||
| bps := float64(config.BWLimit*(1<<20)/8) * 0.85 // 15% overhead | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.