Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: support human friendly values for options #4558

Merged
merged 6 commits into from
Mar 22, 2024
Merged

cmd: support human friendly values for options #4558

merged 6 commits into from
Mar 22, 2024

Conversation

SandyXSD
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 78.35052% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 55.73%. Comparing base (a190f55) to head (f0f12e6).
Report is 2 commits behind head on main.

Files Patch % Lines
cmd/flags.go 69.44% 10 Missing and 1 partial ⚠️
cmd/objbench.go 80.00% 2 Missing and 1 partial ⚠️
pkg/chunk/cached_store.go 0.00% 2 Missing ⚠️
pkg/chunk/disk_cache.go 50.00% 2 Missing ⚠️
cmd/bench.go 94.11% 0 Missing and 1 partial ⚠️
cmd/format.go 90.90% 1 Missing ⚠️
cmd/quota.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4558      +/-   ##
==========================================
+ Coverage   55.66%   55.73%   +0.06%     
==========================================
  Files         157      157              
  Lines       42968    43003      +35     
==========================================
+ Hits        23918    23967      +49     
+ Misses      16393    16376      -17     
- Partials     2657     2660       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SandyXSD SandyXSD requested a review from davies March 22, 2024 03:19
@davies davies merged commit de2611c into main Mar 22, 2024
32 checks passed
@davies davies deleted the human-flags branch March 22, 2024 07:15
zxh326 added a commit to juicedata/juicefs-csi-driver that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants