Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disk cache switch to consistent hash and add bad disk detection #4543

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

jiefenghuang
Copy link
Contributor

close #4540

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 71.08014% with 83 lines in your changes are missing coverage. Please review.

Project coverage is 55.71%. Comparing base (12a3e45) to head (42eec0a).
Report is 4 commits behind head on main.

Files Patch % Lines
pkg/chunk/disk_cache.go 74.80% 50 Missing and 16 partials ⚠️
pkg/chunk/utils_unix.go 33.33% 6 Missing and 2 partials ⚠️
pkg/chunk/cached_store.go 33.33% 5 Missing and 1 partial ⚠️
pkg/chunk/mem_cache.go 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4543      +/-   ##
==========================================
+ Coverage   55.61%   55.71%   +0.09%     
==========================================
  Files         157      157              
  Lines       42702    42941     +239     
==========================================
+ Hits        23749    23924     +175     
- Misses      16317    16358      +41     
- Partials     2636     2659      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: jiefenghuang <[email protected]>
@jiefenghuang jiefenghuang marked this pull request as ready for review March 20, 2024 09:50
pkg/chunk/disk_cache.go Outdated Show resolved Hide resolved
pkg/chunk/disk_cache.go Outdated Show resolved Hide resolved
Signed-off-by: jiefenghuang <[email protected]>
@davies davies merged commit 249ea17 into juicedata:main Mar 21, 2024
32 checks passed
@jiefenghuang jiefenghuang deleted the feat/disk-cache-ft branch April 15, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance disk cache: consistent hash
2 participants