meta/sql: use upsert in Write() to avoid possible deadlock #4529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4529 +/- ##
==========================================
- Coverage 55.68% 55.68% -0.01%
==========================================
Files 157 157
Lines 42605 42618 +13
==========================================
+ Hits 23726 23731 +5
- Misses 16243 16256 +13
+ Partials 2636 2631 -5 ☔ View full report in Codecov by Sentry. |
davies
approved these changes
Mar 18, 2024
davies
approved these changes
Mar 19, 2024
SandyXSD
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4494
The current behavior with possible deadlock is not a bug (see: https://bugs.mysql.com/bug.php?id=96748). However, using upsert seems to be a better way.