fix: config acl #4522
Merged
fix: config acl #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiefenghuang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4522 +/- ##
===========================================
- Coverage 55.69% 35.67% -20.02%
===========================================
Files 157 122 -35
Lines 42593 33428 -9165
===========================================
- Hits 23722 11927 -11795
- Misses 16234 20287 +4053
+ Partials 2637 1214 -1423 ☔ View full report in Codecov by Sentry. |
SandyXSD
reviewed
Mar 15, 2024
cmd/config.go
Outdated
| format.EnableACL = true | ||
| format.MinClientVersion = "1.2.0-A" | ||
| } else { | ||
| fmt.Println("cannot disable acl") |
There was a problem hiding this comment.
i think this is enough, print msg and nothing changed.
SandyXSD
reviewed
Mar 15, 2024
cmd/config.go
Outdated
| if enableACL := ctx.Bool(flag); enableACL != format.EnableACL { | ||
| if enableACL { | ||
| msg.WriteString(fmt.Sprintf("%s: %v -> %v\n", flag, format.EnableACL, true)) | ||
| msg.WriteString(fmt.Sprintf("%s: %s -> %v\n", "min-client-version", format.MinClientVersion, "1.2.0-A")) |
There was a problem hiding this comment.
Suggested change
| msg.WriteString(fmt.Sprintf("%s: %s -> %v\n", "min-client-version", format.MinClientVersion, "1.2.0-A")) | |
| msg.WriteString(fmt.Sprintf("%s: %s -> %s\n", "min-client-version", format.MinClientVersion, "1.2.0-A")) |
Signed-off-by: jiefenghuang <[email protected]>
zhoucheng361
approved these changes
Mar 15, 2024
Signed-off-by: jiefenghuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.