Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/acl: add acl rule and cache #4437

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Conversation

jiefenghuang
Copy link
Contributor

@jiefenghuang jiefenghuang commented Feb 29, 2024

#4409
add acl rule and acl cache which will cache all acl rules

@jiefenghuang

This comment was marked as resolved.

@jiefenghuang jiefenghuang changed the title Feat/acl support feat/acl: add acl rule and cache Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 45.27363% with 110 lines in your changes are missing coverage. Please review.

Project coverage is 55.99%. Comparing base (97c42f4) to head (b01c560).
Report is 7 commits behind head on main.

Files Patch % Lines
pkg/acl/acl.go 22.76% 92 Missing and 3 partials ⚠️
pkg/acl/cache.go 80.76% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4437      +/-   ##
==========================================
- Coverage   56.02%   55.99%   -0.04%     
==========================================
  Files         154      156       +2     
  Lines       40134    40417     +283     
==========================================
+ Hits        22487    22630     +143     
- Misses      15129    15266     +137     
- Partials     2518     2521       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiefenghuang jiefenghuang marked this pull request as ready for review March 4, 2024 02:25
pkg/acl/acl.go Outdated Show resolved Hide resolved
pkg/acl/acl.go Outdated Show resolved Hide resolved
pkg/acl/acl.go Outdated Show resolved Hide resolved
pkg/acl/acl.go Outdated Show resolved Hide resolved
pkg/acl/acl.go Outdated Show resolved Hide resolved
return ((r.Owner & 7) << 6) | ((r.Mask & 7) << 3) | (r.Other & 7)
}

func (r *Rule) ChildAccessACL(mode uint16) *Rule {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add doc for these public API

Signed-off-by: jiefeng <[email protected]>
@jiefenghuang jiefenghuang requested a review from davies March 4, 2024 08:41
"github.com/juicedata/juicefs/pkg/utils"
)

const Version uint8 = 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is it used?

@davies davies merged commit 59659db into juicedata:main Mar 4, 2024
26 checks passed
@jiefenghuang jiefenghuang deleted the feat/acl-cache branch April 15, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants