-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add push-labels
option for java sdk and add --custom-lables
option for mount
#4312
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4312 +/- ##
==========================================
- Coverage 55.81% 55.78% -0.04%
==========================================
Files 153 153
Lines 39631 39654 +23
==========================================
- Hits 22122 22120 -2
- Misses 15030 15053 +23
- Partials 2479 2481 +2 ☔ View full report in Codecov by Sentry. |
Yes |
The above code can only solve the problem of java sdk custom lable, go process also need to be added. Line 162 in 6ef6813
|
OK, I searched the code base with pattern "push-gateway" then I only find the code in java sdk. I'll dive into the golang process code. |
The previous issue was a special case, and we should support |
push-labels
option for java sdk and add --custom-lables
for mount
push-labels
option for java sdk and add --custom-lables
for mountpush-labels
option for java sdk and add --custom-lables
option for mount
Is this PR causing test failure? |
It doesn't matter if |
LGTM! |
close #4245
Does some defensive programming (check the format of parameter) needed ?