Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/java: fix guid update #4299

Merged
merged 7 commits into from
Dec 29, 2023
Merged

sdk/java: fix guid update #4299

merged 7 commits into from
Dec 29, 2023

Conversation

tangyoupeng
Copy link
Contributor

@tangyoupeng tangyoupeng commented Dec 27, 2023

remove old guid from map when update

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b95cf4c) 55.76% compared to head (c12eae6) 55.74%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4299      +/-   ##
==========================================
- Coverage   55.76%   55.74%   -0.02%     
==========================================
  Files         153      153              
  Lines       39594    39596       +2     
==========================================
- Hits        22078    22073       -5     
- Misses      15042    15051       +9     
+ Partials     2474     2472       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tangyoupeng tangyoupeng changed the title add log for gid update f ix gid update Dec 29, 2023
@tangyoupeng tangyoupeng changed the title f ix gid update fix guid update Dec 29, 2023
@tangyoupeng tangyoupeng requested a review from davies December 29, 2023 02:20
@tangyoupeng tangyoupeng marked this pull request as ready for review December 29, 2023 02:21
@davies davies changed the title fix guid update sdk/java: fix guid update Dec 29, 2023
@davies davies added backport-1.0 Backport to release-1.0 branch backport-1.1 labels Dec 29, 2023
@davies davies merged commit 5ecf33a into main Dec 29, 2023
26 checks passed
@davies davies deleted the guid_mapping_log branch December 29, 2023 03:54
@davies davies removed the backport-1.0 Backport to release-1.0 branch label Dec 29, 2023
SandyXSD pushed a commit that referenced this pull request Feb 3, 2024
SandyXSD pushed a commit that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants