-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/mount: add cache-expire
option to set expired time for cached blocks
#4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into format-cached-stay-days
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4255 +/- ##
==========================================
+ Coverage 55.63% 55.73% +0.09%
==========================================
Files 120 153 +33
Lines 31142 39618 +8476
==========================================
+ Hits 17327 22081 +4754
- Misses 11778 15057 +3279
- Partials 2037 2480 +443 ☔ View full report in Codecov by Sentry. |
davies
reviewed
Dec 12, 2023
davies
reviewed
Dec 12, 2023
davies
reviewed
Dec 12, 2023
davies
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes over #3966 .
Note with the new option set, cached blocks will be expired even if the
cache-eviction
is "none".