Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/mount: add cache-expire option to set expired time for cached blocks #4255

Merged
merged 19 commits into from
Dec 13, 2023

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Dec 12, 2023

This PR takes over #3966 .

Note with the new option set, cached blocks will be expired even if the cache-eviction is "none".

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (eb91f8f) 55.63% compared to head (adb2e6c) 55.73%.

Files Patch % Lines
pkg/chunk/disk_cache.go 8.88% 38 Missing and 3 partials ⚠️
pkg/chunk/cached_store.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4255      +/-   ##
==========================================
+ Coverage   55.63%   55.73%   +0.09%     
==========================================
  Files         120      153      +33     
  Lines       31142    39618    +8476     
==========================================
+ Hits        17327    22081    +4754     
- Misses      11778    15057    +3279     
- Partials     2037     2480     +443     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/chunk/disk_cache.go Outdated Show resolved Hide resolved
@SandyXSD SandyXSD merged commit c951522 into main Dec 13, 2023
31 checks passed
@SandyXSD SandyXSD deleted the cache-expire branch December 13, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants