Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/mount: add option upload-hours to limit the period for background uploads #4250

Merged
merged 12 commits into from
Dec 12, 2023

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Dec 12, 2023

This PR takes over #3947

Note it's still possible for staged blocks to be uploaded beyond the limited hours, if the cache directory is full, just like how the upload-delay works.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (1dd17de) 55.70% compared to head (edb00a5) 55.66%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/chunk/cached_store.go 28.57% 29 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4250      +/-   ##
==========================================
- Coverage   55.70%   55.66%   -0.04%     
==========================================
  Files         154      154              
  Lines       39569    39629      +60     
==========================================
+ Hits        22042    22060      +18     
- Misses      15060    15093      +33     
- Partials     2467     2476       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davies davies merged commit 124f58d into main Dec 12, 2023
31 checks passed
@davies davies deleted the upload-hours branch December 12, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants