Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object: fix verify checksum #4213

Merged
merged 6 commits into from
Nov 30, 2023
Merged

object: fix verify checksum #4213

merged 6 commits into from
Nov 30, 2023

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Nov 29, 2023

close #4210

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (52d7c7d) 55.56% compared to head (7bb3bd3) 55.61%.
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/object/oss.go 0.00% 7 Missing ⚠️
pkg/object/cos.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4213      +/-   ##
==========================================
+ Coverage   55.56%   55.61%   +0.04%     
==========================================
  Files         154      154              
  Lines       39492    39531      +39     
==========================================
+ Hits        21944    21985      +41     
+ Misses      15094    15087       -7     
- Partials     2454     2459       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhijian-pro zhijian-pro marked this pull request as ready for review November 29, 2023 09:12
pkg/object/oss.go Outdated Show resolved Hide resolved
pkg/object/checksum.go Outdated Show resolved Hide resolved
@davies davies changed the title object/s3&oss&cos: fix get content checksum object: fix verify checksum Nov 29, 2023
@davies davies added backport-1.1 backport-1.0 Backport to release-1.0 branch and removed backport-1.0 Backport to release-1.0 branch labels Nov 30, 2023
@davies davies merged commit 5b8610f into main Nov 30, 2023
35 of 37 checks passed
@davies davies deleted the fix-crc-check branch November 30, 2023 06:48
SandyXSD pushed a commit that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

juicefs objectstore checker bug
2 participants