same owner should be able to convert an EXCLUSIVE lock to a SHARED lock by requesting the SHARED lock (redis meta, flock, posix) #4197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dbotwinick
changed the title
|
This is already fixed in main branch by #4179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the call to delete lkey from owners in meta/redis_lock.go so that flock would support converting an EXCLUSIVE lock to a SHARED lock for the same owner. As originally implemented, if there is any WRITE lock, then the lock operation should return EAGAIN which is problematic for calls that are not explicitly non-blocking intended to convert an EXCLUSIVE lock to a SHARED lock. I've been coming across blocking lock "downgrade" scenarios for database software.
TODO: