Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/mount: add option skip-dir-mtime to eliminate burst mtime updates of a directory #4189

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Nov 23, 2023

No description provided.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a40759) 55.57% compared to head (4416b30) 55.60%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4189      +/-   ##
==========================================
+ Coverage   55.57%   55.60%   +0.02%     
==========================================
  Files         154      154              
  Lines       39492    39498       +6     
==========================================
+ Hits        21949    21963      +14     
+ Misses      15085    15078       -7     
+ Partials     2458     2457       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SandyXSD SandyXSD requested a review from davies November 28, 2023 03:03
@davies
Copy link
Contributor

davies commented Nov 28, 2023

The argument should be explicit about updating mtime of parent dir.

@SandyXSD SandyXSD changed the title cmd/mount: add option min-update-time to eliminate burst mtime updates cmd/mount: add option skip-dir-mtime to eliminate burst mtime updates Nov 29, 2023
@SandyXSD SandyXSD changed the title cmd/mount: add option skip-dir-mtime to eliminate burst mtime updates cmd/mount: add option skip-dir-mtime to eliminate burst mtime updates of a directory Nov 29, 2023
@davies davies merged commit ec24896 into main Nov 29, 2023
31 checks passed
@davies davies deleted the min-update-time branch November 29, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants