Time duration can identify the number of days #4002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davies
reviewed
Sep 20, 2023
| @@ -323,7 +325,51 @@ func expandFlags(compoundFlags ...[]cli.Flag) []cli.Flag { | |||
| return flags | |||
| } | |||
|
|
|||
| func parseDuration(input string) (time.Duration, error) { | |||
There was a problem hiding this comment.
We can use time.ParseDuration to cover most of the cases, and handle 7d here.
|
took over by #4246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios, the time parameter supports days, which is better. For example, data is rarely modified and the backup interval is expected to be one week. Although 168h can also be used, 7d is more intuitive, such as --backup-meta 7d.