Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor hdfs kerberos keytab load #3874

Merged
merged 3 commits into from
Jul 5, 2023
Merged

refactor hdfs kerberos keytab load #3874

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2da52c
refactor hdfs kerberos keytab load
tangyoupeng Jul 4, 2023
6b65439
KRB5PRINCIPAL must be set if KRB5KEYTAB or KRB5KEYTAB_BASE64 is set
tangyoupeng Jul 5, 2023
8e88572
Update hdfs_kerberos.go
davies Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions pkg/object/hdfs_kerberos.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,10 @@ package object

import (
"encoding/base64"
"encoding/binary"
"fmt"
"github.com/jcmturner/gokrb5/v8/keytab"
"os"
"os/user"
"path/filepath"
"strings"

krb "github.com/jcmturner/gokrb5/v8/client"
Expand All @@ -35,30 +33,26 @@ func getKerberosClient() (*krb.Client, error) {
// Try to authenticate with keytab file first.
keytabPath := os.Getenv("KRB5KEYTAB")
keytabBase64 := os.Getenv("KRB5KEYTAB_BASE64")
principal := os.Getenv("KRB5PRINCIPAL")

var kt *keytab.Keytab
if keytabBase64 != "" {
decodedKeytab, err := base64.StdEncoding.DecodeString(keytabBase64)
if err != nil {
return nil, fmt.Errorf("error decoding Base64 encoded data %s", err)
}
decodedKeytabPath := filepath.Join(os.TempDir(), "decodedKeytab")
decodedKeytabFile, err := os.Create(decodedKeytabPath)
if err != nil {
return nil, fmt.Errorf("failed to create %s", decodedKeytabPath)
}
defer decodedKeytabFile.Close()
// keytab file format uses network byte order
err = binary.Write(decodedKeytabFile, binary.BigEndian, decodedKeytab)
kt = new(keytab.Keytab)
err = kt.Unmarshal(decodedKeytab)
if err != nil {
return nil, fmt.Errorf("failed to write %s", decodedKeytabPath)
return nil, err
}
keytabPath = decodedKeytabPath
}
principal := os.Getenv("KRB5PRINCIPAL")
if keytabPath != "" && principal != "" {
kt, err := keytab.Load(keytabPath)
} else if keytabPath != "" {
kt, err = keytab.Load(keytabPath)
if err != nil {
return nil, err
}
}
if kt != nil && principal != "" {
tangyoupeng marked this conversation as resolved.
Show resolved Hide resolved
// e.g. KRB5PRINCIPAL="primary/instance@realm"
sp := strings.Split(principal, "@")
if len(sp) != 2 {
Expand Down