Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: track atime for ReadLink as well #3591

Merged
merged 7 commits into from
May 12, 2023
Merged

meta: track atime for ReadLink as well #3591

merged 7 commits into from
May 12, 2023

Conversation

SandyXSD
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 57.00% and project coverage change: -0.30 ⚠️

Comparison is base (49d994d) 56.16% compared to head (cdc9658) 55.87%.

❗ Current head cdc9658 differs from pull request most recent head c9b88f2. Consider uploading reports for the commit c9b88f2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3591      +/-   ##
==========================================
- Coverage   56.16%   55.87%   -0.30%     
==========================================
  Files         149      148       -1     
  Lines       37087    37107      +20     
==========================================
- Hits        20829    20732      -97     
- Misses      13962    14075     +113     
- Partials     2296     2300       +4     
Impacted Files Coverage Δ
pkg/meta/sql.go 57.48% <44.73%> (-1.12%) ⬇️
pkg/meta/redis.go 65.85% <60.00%> (-0.84%) ⬇️
pkg/meta/tkv.go 70.57% <65.21%> (-1.15%) ⬇️
pkg/meta/base.go 62.46% <66.66%> (-0.69%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davies
Copy link
Contributor

davies commented May 11, 2023

Please add unit test to cover these

@github-actions
Copy link

@github-actions
Copy link

Mutate Test Report
pkg/vfs/vfs_test.go-1-4: score:0.46 failed:52, passed:45, compile error:29, out of coverage:5, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4956617024/jobs/8867322825

pkg/vfs/vfs_test.go-3-4: score:0.39 failed:70, passed:45, compile error:14, out of coverage:2, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4956617024/jobs/8867323101

pkg/vfs/vfs_test.go-2-4: score:0.26 failed:93, passed:32, compile error:0, out of coverage:6, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4956617024/jobs/8867322965

pkg/vfs/vfs_test.go-4-4: score:0.52 failed:51, passed:55, compile error:10, out of coverage:14, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4956617024/jobs/8867323213

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@github-actions
Copy link

Mutate Test Report
pkg/vfs/vfs_test.go-1-4: score:0.46 failed:52, passed:45, compile error:29, out of coverage:5, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4957574912/jobs/8869459285

pkg/vfs/vfs_test.go-3-4: score:0.39 failed:70, passed:45, compile error:14, out of coverage:2, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4957574912/jobs/8869459559

pkg/vfs/vfs_test.go-4-4: score:0.52 failed:51, passed:55, compile error:10, out of coverage:14, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4957574912/jobs/8869459672

pkg/vfs/vfs_test.go-2-4: score:0.26 failed:93, passed:32, compile error:0, out of coverage:6, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4957574912/jobs/8869459441

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@SandyXSD SandyXSD requested a review from davies May 12, 2023 11:57
@github-actions
Copy link

Mutate Test Report
pkg/meta/utils_test.go-2-4: score:0.33 failed:2, passed:1, compile error:0, out of coverage:50, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4958407934/jobs/8871262832

pkg/meta/utils_test.go-1-4: score:0.00 failed:0, passed:0, compile error:1, out of coverage:52, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4958407934/jobs/8871262721

pkg/meta/utils_test.go-4-4: score:0.00 failed:2, passed:0, compile error:0, out of coverage:48, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4958407934/jobs/8871263025

pkg/meta/utils_test.go-3-4: score:0.88 failed:1, passed:7, compile error:3, out of coverage:42, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4958407934/jobs/8871262923

pkg/fuse/fuse_test.go-1-1: score:0.21 failed:50, passed:13, compile error:11, out of coverage:37, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4958407934/jobs/8871262582

pkg/vfs/vfs_test.go-1-4: score:0.46 failed:52, passed:45, compile error:29, out of coverage:5, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4958407934/jobs/8871263128

pkg/vfs/vfs_test.go-3-4: score:0.39 failed:70, passed:45, compile error:14, out of coverage:2, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4958407934/jobs/8871263351

pkg/vfs/vfs_test.go-4-4: score:0.52 failed:51, passed:55, compile error:10, out of coverage:14, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4958407934/jobs/8871263442

pkg/vfs/vfs_test.go-2-4: score:0.26 failed:93, passed:32, compile error:0, out of coverage:6, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4958407934/jobs/8871263246

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@davies davies merged commit d7260e0 into main May 12, 2023
@davies davies deleted the readlink-atime branch May 12, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants