Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: support storage class flag for sdk #3588

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented May 11, 2023

close #3587

@zhijian-pro zhijian-pro requested review from davies and tangyoupeng May 11, 2023 04:09
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (316b71d) 56.01% compared to head (eff0c4c) 55.99%.

❗ Current head eff0c4c differs from pull request most recent head e1a9963. Consider uploading reports for the commit e1a9963 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3588      +/-   ##
==========================================
- Coverage   56.01%   55.99%   -0.02%     
==========================================
  Files         149      149              
  Lines       37118    37118              
==========================================
- Hits        20791    20786       -5     
- Misses      14041    14046       +5     
  Partials     2286     2286              

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhijian-pro zhijian-pro force-pushed the sdk_support_storageclass branch from eff0c4c to e1a9963 Compare May 11, 2023 07:28
@davies davies merged commit d4f11dd into main May 11, 2023
@davies davies deleted the sdk_support_storageclass branch May 11, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java SDK support storageClass
2 participants