Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: move touchAtime to base meta #3585

Merged
merged 1 commit into from
May 11, 2023
Merged

meta: move touchAtime to base meta #3585

merged 1 commit into from
May 11, 2023

Conversation

SandyXSD
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Patch coverage: 74.46% and project coverage change: +0.18 🎉

Comparison is base (1770458) 55.98% compared to head (8cc27d1) 56.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3585      +/-   ##
==========================================
+ Coverage   55.98%   56.16%   +0.18%     
==========================================
  Files         149      148       -1     
  Lines       37031    36976      -55     
==========================================
+ Hits        20732    20768      +36     
+ Misses      14020    13932      -88     
+ Partials     2279     2276       -3     
Impacted Files Coverage Δ
pkg/meta/sql.go 58.62% <54.54%> (+0.64%) ⬆️
pkg/meta/redis.go 66.86% <66.66%> (+0.72%) ⬆️
pkg/meta/base.go 63.14% <85.00%> (+0.47%) ⬆️
pkg/meta/tkv.go 71.54% <85.71%> (+0.90%) ⬆️

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SandyXSD SandyXSD requested a review from davies May 11, 2023 07:14
return nil
})
updated = true
if err = tx.Set(ctx, m.inodeKey(inode), m.marshal(attr), 0).Err(); err == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use pipeline to end a transaction, if there is only one operation

@davies davies merged commit 49d994d into main May 11, 2023
@davies davies deleted the adjust-atime branch May 11, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants