Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support root squash #3575

Merged
merged 2 commits into from
May 10, 2023
Merged

support root squash #3575

merged 2 commits into from
May 10, 2023

Conversation

Hexilee
Copy link
Contributor

@Hexilee Hexilee commented May 10, 2023

close #3562

@Hexilee Hexilee requested a review from SandyXSD May 10, 2023 04:44
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Patch coverage: 78.94% and project coverage change: -1.10 ⚠️

Comparison is base (8cb2bb8) 56.47% compared to head (0589383) 55.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3575      +/-   ##
==========================================
- Coverage   56.47%   55.38%   -1.10%     
==========================================
  Files         149      117      -32     
  Lines       36422    29174    -7248     
==========================================
- Hits        20571    16157    -4414     
+ Misses      13599    11150    -2449     
+ Partials     2252     1867     -385     
Impacted Files Coverage Δ
pkg/vfs/vfs.go 73.46% <ø> (-2.78%) ⬇️
pkg/fuse/context.go 46.66% <20.00%> (-19.19%) ⬇️
pkg/fuse/fuse.go 70.24% <87.87%> (-7.17%) ⬇️

... and 95 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/mount_unix.go Outdated Show resolved Hide resolved
@Hexilee Hexilee merged commit 1770458 into main May 10, 2023
@Hexilee Hexilee deleted the root-squash branch May 10, 2023 07:38
@@ -128,6 +131,10 @@ func mount_flags() []cli.Flag {
Value: path.Join(defaultLogDir, "juicefs.log"),
Usage: "path of log file when running in background",
},
&cli.StringFlag{
Name: "root-squash",
Usage: "map local root user (uid = 0) to another one in filesystem",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Usage: "map local root user (uid = 0) to another one in filesystem",
Usage: "map local root user (uid = 0) to another one specified as <uid>:<gid>",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support root squash
3 participants