Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object: support storage class #3534

Merged
merged 9 commits into from
May 6, 2023
Merged

object: support storage class #3534

merged 9 commits into from
May 6, 2023

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Apr 26, 2023

Create bucket Put object Multipart Upload Copy effective value
b2 No No No No
azure No YES
bos YES YES YES STANDARD,STANDARD_IA,COLD,ARCHIVE
ceph No No No No
cos No Yes Yes STANDARD、STANDARD_IA、ARCHIVE 等
eos S3
gs yes Yes "STANDARD", "NEARLINE", "COLDLINE" and "ARCHIVE"
Ibmcos Yes Yes Yes https://cloud.ibm.com/docs/cloud-object-storage?topic=cloud-object-storage-classes&code=go
S3 no Yes Yes Yes https://docs.aws.amazon.com/AmazonS3/latest/userguide/storage-class-intro.html
jss S3
ks3 no yes yes Yes STANDARD/ STANDARD_IA/ARCHIVE
Minio s3
Obs yes yes Yes STANDARD WARM COLD STANDARD_IA GLACIER
oos no S3 S3
oss yes yes yes Standard IA Archive ColdArchive
Qingstor no yes Yes yes STANDARD, STANDARD_IA
Qiniu no no no No
Scs No No No No
Scw S3 STANDARD (multi-zone), ONEZONE_IA (one-zone).
swift no no no no

close #3497

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Patch coverage: 14.05% and project coverage change: -0.22 ⚠️

Comparison is base (8cb2bb8) 56.47% compared to head (924bbcc) 56.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3534      +/-   ##
==========================================
- Coverage   56.47%   56.26%   -0.22%     
==========================================
  Files         149      149              
  Lines       36422    36747     +325     
==========================================
+ Hits        20571    20674     +103     
- Misses      13599    13813     +214     
- Partials     2252     2260       +8     
Impacted Files Coverage Δ
cmd/mount.go 55.67% <0.00%> (-0.35%) ⬇️
pkg/meta/config.go 48.61% <ø> (ø)
pkg/object/azure.go 1.18% <0.00%> (-0.33%) ⬇️
pkg/object/b2.go 1.63% <0.00%> (-0.03%) ⬇️
pkg/object/bos.go 1.03% <0.00%> (-0.08%) ⬇️
pkg/object/cos.go 0.89% <0.00%> (-0.11%) ⬇️
pkg/object/eos.go 4.00% <0.00%> (ø)
pkg/object/gs.go 1.68% <0.00%> (-0.08%) ⬇️
pkg/object/ibmcos.go 0.90% <0.00%> (-0.09%) ⬇️
pkg/object/jss.go 4.76% <0.00%> (-0.37%) ⬇️
... and 37 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@solracsf
Copy link
Contributor

solracsf commented Apr 27, 2023

Scaleway (scw) can support STANDARD (multi-zone), ONEZONE_IA (one-zone).
https://www.scaleway.com/en/docs/storage/object/concepts/#storage-class

@zhijian-pro
Copy link
Contributor Author

Juicefs does not examine storage classes, and we need to inform the user in the documentation that storage types that need to be unfrozen before reading are not currently supported.

cmd/format.go Outdated Show resolved Hide resolved
cmd/format.go Outdated Show resolved Hide resolved
cmd/flags.go Outdated Show resolved Hide resolved
cmd/config.go Outdated Show resolved Hide resolved
cmd/mount.go Show resolved Hide resolved
cmd/sync.go Outdated Show resolved Hide resolved
pkg/meta/config.go Outdated Show resolved Hide resolved
pkg/object/bos.go Outdated Show resolved Hide resolved
pkg/object/bos.go Outdated Show resolved Hide resolved
@davies
Copy link
Contributor

davies commented Apr 28, 2023

@zhijian-pro please update the unit test to cover storage class, also the objbench (could be another PR)

@davies davies closed this Apr 28, 2023
@davies davies reopened this Apr 28, 2023
@zhijian-pro zhijian-pro force-pushed the support_storage_class branch from 59553d2 to 6e0f82f Compare April 28, 2023 10:22
@zhijian-pro
Copy link
Contributor Author

There was a bug in the azure-sdk-for-go version of v0.3.0, so I temporarily upgraded to v0.4.0.

@davies davies marked this pull request as ready for review May 5, 2023 15:58
@davies davies merged commit 236bad0 into main May 6, 2023
@davies davies deleted the support_storage_class branch May 6, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support StorageClass for object storage
4 participants