vfs: introduce --atime-mode option to control atime update behavior #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
davies
reviewed
Apr 25, 2023
davies
reviewed
Apr 25, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3521 +/- ##
==========================================
- Coverage 56.40% 56.05% -0.35%
==========================================
Files 149 149
Lines 36420 36992 +572
==========================================
+ Hits 20542 20737 +195
- Misses 13620 13978 +358
- Partials 2258 2277 +19
☔ View full report in Codecov by Sentry. |
|
Any advise on how tho fix this markdown lint error? |
Add one space around the numbers, and between Chinese word and English word. |
eryugey
force-pushed
the
dev
branch
2 times, most recently
from
1fe64e8 to
0e90d62
Compare
SandyXSD
reviewed
Apr 27, 2023
SandyXSD
reviewed
May 6, 2023
|
We should also check and update the atime in Well, |
Currently juicefs doesn't update atime on access, so introduce --atime-mode option to select how to update atime. And support three modes: - noatime: don't update atime - relatime: update atime relative to motify or change time - strictatime: always update atime Fixes: juicedata#3240 Signed-off-by: Eryu Guan <[email protected]>
To avoid getting attr from meta server on each atime update. Signed-off-by: Eryu Guan <[email protected]>
To avoid getting attr again. Signed-off-by: Eryu Guan <[email protected]>
Added touchAtime() in Open() as well. |
SandyXSD
reviewed
May 8, 2023
Transaction is expensive, we could avoid starting a transaction when touchAtime() was given a current attr, so we don't have to get attr first. Signed-off-by: Eryu Guan <[email protected]>
To avoid multiple atime updates in short time. Signed-off-by: Eryu Guan <[email protected]>
Signed-off-by: Eryu Guan <[email protected]>
davies
reviewed
May 8, 2023
davies
reviewed
May 8, 2023
davies
reviewed
May 8, 2023
SandyXSD
reviewed
May 9, 2023
Signed-off-by: Eryu Guan <[email protected]>
SandyXSD
approved these changes
May 9, 2023
|
Thanks all for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently juicefs doesn't update atime on access, so introduce --atime-mode option to select how to update atime. And support three modes:
Fixes: #3240
Signed-off-by: Eryu Guan [email protected]