Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/mount: add an option cache-eviction to specify the policy #3478

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Apr 17, 2023

close #3473

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Patch coverage: 59.25% and project coverage change: -0.11 ⚠️

Comparison is base (7ed768b) 56.34% compared to head (f291465) 56.23%.

❗ Current head f291465 differs from pull request most recent head 3acc01c. Consider uploading reports for the commit 3acc01c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3478      +/-   ##
==========================================
- Coverage   56.34%   56.23%   -0.11%     
==========================================
  Files         149      149              
  Lines       36277    36296      +19     
==========================================
- Hits        20440    20412      -28     
- Misses      13609    13665      +56     
+ Partials     2228     2219       -9     
Impacted Files Coverage Δ
pkg/chunk/cached_store.go 72.23% <ø> (ø)
pkg/chunk/mem_cache.go 56.17% <16.66%> (-2.86%) ⬇️
pkg/chunk/disk_cache.go 68.07% <62.50%> (-4.49%) ⬇️
cmd/flags.go 93.99% <100.00%> (+0.10%) ⬆️
cmd/mount.go 56.01% <100.00%> (+0.09%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SandyXSD SandyXSD requested a review from davies April 17, 2023 09:23
@SandyXSD SandyXSD changed the title cmd/mount: add an option cache-no-eviction to disable cache eviction cmd/mount: add an option cache-eviction to specify the policy Apr 17, 2023
@davies davies merged commit ba1d474 into main Apr 18, 2023
@davies davies deleted the cache-no-eviction branch April 18, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to Change Cache Obsolescence Policy
3 participants