Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/mount: add single-mode option to skips the heartbeat and metadata synchronization #3465

Closed
wants to merge 1 commit into from

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Apr 11, 2023

close #3329

We need the heartbeat as a ticker to reload new configurations (conf, quota, etc.). So instead of setting heartbeat to 0, we may add a new single node mode, which skips the management of sessions and synchronization of background tasks.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 30.00% and project coverage change: -0.07 ⚠️

Comparison is base (a3b7ea8) 56.40% compared to head (86b31ed) 56.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3465      +/-   ##
==========================================
- Coverage   56.40%   56.34%   -0.07%     
==========================================
  Files         149      149              
  Lines       36239    36257      +18     
==========================================
- Hits        20440    20428      -12     
- Misses      13581    13616      +35     
+ Partials     2218     2213       -5     
Impacted Files Coverage Δ
pkg/meta/config.go 50.69% <ø> (ø)
pkg/meta/base.go 64.39% <20.00%> (-0.30%) ⬇️
cmd/flags.go 93.99% <100.00%> (+0.10%) ⬆️
cmd/mount.go 56.01% <100.00%> (+0.09%) ⬆️

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davies
Copy link
Contributor

davies commented Apr 12, 2023

We don't need single mode for now.

@davies davies closed this Apr 12, 2023
@davies davies deleted the single-mode branch June 7, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to disable client heartbeat
3 participants