Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add IPAddrs to the session info #3464

Merged
merged 4 commits into from
Apr 12, 2023
Merged

meta: add IPAddrs to the session info #3464

merged 4 commits into from
Apr 12, 2023

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Apr 11, 2023

close #3295

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023

Codecov Report

Patch coverage: 58.33% and project coverage change: +0.02 🎉

Comparison is base (26fe83d) 56.34% compared to head (8c373b4) 56.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3464      +/-   ##
==========================================
+ Coverage   56.34%   56.37%   +0.02%     
==========================================
  Files         149      149              
  Lines       36242    36255      +13     
==========================================
+ Hits        20419    20437      +18     
  Misses      13605    13605              
+ Partials     2218     2213       -5     
Impacted Files Coverage Δ
pkg/meta/interface.go 55.00% <ø> (ø)
pkg/meta/base.go 64.63% <46.15%> (+0.14%) ⬆️
pkg/sync/cluster.go 26.55% <60.00%> (-1.04%) ⬇️
pkg/utils/utils.go 72.83% <64.00%> (-1.62%) ⬇️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SandyXSD SandyXSD requested a review from davies April 11, 2023 08:38
pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/utils/utils.go Outdated Show resolved Hide resolved
@davies davies merged commit 3cf54c2 into main Apr 12, 2023
@davies davies deleted the add-ip branch April 12, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants