Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve parallelism for summary #3423

Merged
merged 6 commits into from
Apr 6, 2023
Merged

improve parallelism for summary #3423

merged 6 commits into from
Apr 6, 2023

Conversation

davies
Copy link
Contributor

@davies davies commented Apr 3, 2023

Improve the parallelism for summary when the structure of directories is not perfect.

@davies davies requested a review from Hexilee April 3, 2023 08:04
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.36 failed:96, passed:55, compile error:43, out of coverage:35, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4594314049/jobs/8113241651

pkg/meta/base_test.go-2-4: score:0.26 failed:126, passed:44, compile error:22, out of coverage:38, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4594314049/jobs/8113241886

pkg/meta/base_test.go-4-4: score:0.51 failed:98, passed:100, compile error:16, out of coverage:15, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4594314049/jobs/8113242224

pkg/meta/base_test.go-3-4: score:0.38 failed:130, passed:79, compile error:12, out of coverage:9, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4594314049/jobs/8113242046

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.36 failed:96, passed:55, compile error:43, out of coverage:35, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4594377176/jobs/8113390521

pkg/meta/base_test.go-2-4: score:0.26 failed:126, passed:44, compile error:22, out of coverage:38, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4594377176/jobs/8113390790

pkg/meta/base_test.go-4-4: score:0.50 failed:99, passed:99, compile error:16, out of coverage:15, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4594377176/jobs/8113391112

pkg/meta/base_test.go-3-4: score:0.39 failed:128, passed:81, compile error:12, out of coverage:9, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4594377176/jobs/8113390945

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.36 failed:96, passed:55, compile error:43, out of coverage:35, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4594350751/jobs/8113314310

pkg/meta/base_test.go-2-4: score:0.26 failed:126, passed:44, compile error:22, out of coverage:38, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4594350751/jobs/8113314605

pkg/meta/base_test.go-4-4: score:0.50 failed:99, passed:99, compile error:16, out of coverage:15, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4594350751/jobs/8113314931

pkg/meta/base_test.go-3-4: score:0.38 failed:129, passed:80, compile error:12, out of coverage:9, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4594350751/jobs/8113314774

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.36 failed:96, passed:55, compile error:43, out of coverage:35, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4595297848/jobs/8115417894

pkg/meta/base_test.go-2-4: score:0.26 failed:126, passed:44, compile error:22, out of coverage:38, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4595297848/jobs/8115418056

pkg/meta/base_test.go-4-4: score:0.50 failed:99, passed:99, compile error:16, out of coverage:15, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4595297848/jobs/8115418292

pkg/meta/base_test.go-3-4: score:0.38 failed:128, passed:80, compile error:12, out of coverage:10, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4595297848/jobs/8115418177

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@davies davies force-pushed the improve_parallel branch from e6e4206 to 67b1f67 Compare April 3, 2023 13:14
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Mutate Test Report
pkg/object/filesystem_test.go-1-1: score:0.00 failed:0, passed:0, compile error:0, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4596998011/jobs/8119192136

pkg/meta/base_test.go-1-4: score:0.36 failed:96, passed:55, compile error:43, out of coverage:35, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4596998011/jobs/8119191376

pkg/meta/base_test.go-2-4: score:0.26 failed:126, passed:44, compile error:22, out of coverage:38, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4596998011/jobs/8119191628

pkg/meta/base_test.go-4-4: score:0.50 failed:99, passed:99, compile error:16, out of coverage:15, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4596998011/jobs/8119191951

pkg/meta/base_test.go-3-4: score:0.38 failed:129, passed:79, compile error:12, out of coverage:10, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4596998011/jobs/8119191801

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.36 failed:96, passed:55, compile error:43, out of coverage:35, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4597127067/jobs/8119472774

pkg/meta/base_test.go-2-4: score:0.26 failed:126, passed:44, compile error:22, out of coverage:38, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4597127067/jobs/8119473090

pkg/meta/base_test.go-4-4: score:0.50 failed:99, passed:99, compile error:16, out of coverage:15, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4597127067/jobs/8119473561

pkg/meta/base_test.go-3-4: score:0.39 failed:127, passed:81, compile error:12, out of coverage:10, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4597127067/jobs/8119473309

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023 •
edited
Loading

Codecov Report

Patch coverage: 36.11% and project coverage change: +0.07 🎉

Comparison is base (6b7a267) 56.31% compared to head (67b1f67) 56.38%.

❗ Current head 67b1f67 differs from pull request most recent head 542e45b. Consider uploading reports for the commit 542e45b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3423      +/-   ##
==========================================
+ Coverage   56.31%   56.38%   +0.07%     
==========================================
  Files         148      148              
  Lines       36143    36082      -61     
==========================================
- Hits        20353    20344       -9     
+ Misses      13571    13535      -36     
+ Partials     2219     2203      -16
Impacted Files Coverage Δ
pkg/meta/interface.go 55.00% <ø> (ø)
pkg/meta/base.go 64.07% <33.33%> (ø)
pkg/meta/utils.go 51.73% <34.78%> (+0.46%) ⬆️
pkg/fs/fs.go 74.94% <100.00%> (ø)
pkg/vfs/internal.go 49.18% <100.00%> (-0.42%) ⬇️

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Hexilee
Hexilee reviewed Apr 6, 2023
View reviewed changes
pkg/meta/utils.go Outdated Show resolved Hide resolved
@Hexilee Hexilee self-requested a review April 6, 2023 10:29
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.37 failed:94, passed:56, compile error:43, out of coverage:36, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4627335647/jobs/8185186939

pkg/meta/base_test.go-2-4: score:0.26 failed:127, passed:44, compile error:22, out of coverage:37, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4627335647/jobs/8185187141

pkg/meta/base_test.go-4-4: score:0.50 failed:98, passed:98, compile error:16, out of coverage:16, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4627335647/jobs/8185187529

pkg/meta/base_test.go-3-4: score:0.39 failed:126, passed:80, compile error:12, out of coverage:12, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4627335647/jobs/8185187386

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@davies davies merged commit 67c2e24 into main Apr 6, 2023
@davies davies deleted the improve_parallel branch April 6, 2023 11:50
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.37 failed:94, passed:56, compile error:43, out of coverage:36, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4627712290/jobs/8185997887

pkg/meta/base_test.go-2-4: score:0.26 failed:127, passed:44, compile error:22, out of coverage:37, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4627712290/jobs/8185998121

pkg/meta/base_test.go-4-4: score:0.49 failed:99, passed:97, compile error:16, out of coverage:16, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4627712290/jobs/8185998462

pkg/meta/base_test.go-3-4: score:0.39 failed:125, passed:81, compile error:12, out of coverage:12, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4627712290/jobs/8185998276

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hexilee Hexilee Hexilee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davies @codecov-commenter @Hexilee