Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/clone: clean the detached nodes in the gc command #3366

Merged
merged 11 commits into from
Mar 28, 2023
Merged

cmd/clone: clean the detached nodes in the gc command #3366

merged 11 commits into from
Mar 28, 2023

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Mar 23, 2023 •
edited
Loading

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023 •
edited
Loading

Codecov Report

Patch coverage: 48.38% and project coverage change: +0.15 🎉

Comparison is base (75643f7) 55.06% compared to head (96d87c5) 55.22%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3366      +/-   ##
==========================================
+ Coverage   55.06%   55.22%   +0.15%     
==========================================
  Files         148      148              
  Lines       36123    36202      +79     
==========================================
+ Hits        19892    19991      +99     
+ Misses      14079    14043      -36     
- Partials     2152     2168      +16
Impacted Files Coverage Δ
pkg/meta/base.go 64.16% <0.00%> (-0.33%) ⬇️
pkg/meta/interface.go 55.00% <ø> (ø)
cmd/gc.go 12.33% <33.33%> (-0.17%) ⬇️
pkg/meta/sql.go 57.86% <45.00%> (+0.52%) ⬆️
pkg/meta/redis.go 65.68% <55.00%> (+0.26%) ⬆️
pkg/meta/tkv.go 69.96% <58.53%> (+0.32%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhijian-pro zhijian-pro marked this pull request as ready for review March 23, 2023 07:41
@zhijian-pro zhijian-pro changed the title cmd/clone: clean up the detached tree in the background cmd/clone: clean the detached nodes in the gc command and refactor Mar 23, 2023
davies
davies reviewed Mar 27, 2023
View reviewed changes
pkg/meta/base.go Outdated Show resolved Hide resolved
@zhijian-pro zhijian-pro changed the title cmd/clone: clean the detached nodes in the gc command and refactor cmd/clone: clean the detached nodes in the gc command Mar 28, 2023
@zhijian-pro zhijian-pro force-pushed the clean_detached_node branch from 4416763 to 1c3e662 Compare March 28, 2023 03:52
@zhijian-pro
Merge branch 'main' into clean_detached_node
8e85eb4 
# Conflicts:
#	pkg/meta/sql.go
#	pkg/meta/tkv.go
@zhijian-pro
merge main
3afb9b2
davies
davies reviewed Mar 28, 2023
View reviewed changes
pkg/meta/sql.go Outdated Show resolved Hide resolved
davies
davies reviewed Mar 28, 2023
View reviewed changes
pkg/meta/tkv.go Outdated Show resolved Hide resolved
@zhijian-pro zhijian-pro force-pushed the clean_detached_node branch from 675499c to aadb38c Compare March 28, 2023 05:24
@zhijian-pro zhijian-pro requested a review from davies March 28, 2023 05:42
davies
davies reviewed Mar 28, 2023
View reviewed changes
pkg/meta/sql.go Outdated Show resolved Hide resolved
davies
davies reviewed Mar 28, 2023
View reviewed changes
pkg/meta/sql.go Outdated Show resolved Hide resolved
davies
davies reviewed Mar 28, 2023
View reviewed changes
pkg/meta/redis.go Outdated Show resolved Hide resolved
davies
davies reviewed Mar 28, 2023
View reviewed changes
pkg/meta/tkv.go Outdated Show resolved Hide resolved
@zhijian-pro zhijian-pro force-pushed the clean_detached_node branch 2 times, most recently from f7a4f4d to 3514f7c Compare March 28, 2023 09:31
@github-actions
Copy link

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.32 failed:92, passed:44, compile error:40, out of coverage:31, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4540820156/jobs/8002244965

pkg/meta/base_test.go-2-4: score:0.24 failed:125, passed:40, compile error:18, out of coverage:25, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4540820156/jobs/8002245236

pkg/meta/base_test.go-4-4: score:0.52 failed:84, passed:91, compile error:16, out of coverage:13, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4540820156/jobs/8002245618

pkg/meta/base_test.go-3-4: score:0.39 failed:115, passed:72, compile error:12, out of coverage:9, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4540820156/jobs/8002245439

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@github-actions
Copy link

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.32 failed:92, passed:44, compile error:40, out of coverage:31, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4540867996/jobs/8002352947

pkg/meta/base_test.go-2-4: score:0.25 failed:124, passed:41, compile error:18, out of coverage:25, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4540867996/jobs/8002353223

pkg/meta/base_test.go-4-4: score:0.51 failed:85, passed:90, compile error:16, out of coverage:13, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4540867996/jobs/8002353582

pkg/meta/base_test.go-3-4: score:0.39 failed:115, passed:72, compile error:12, out of coverage:9, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4540867996/jobs/8002353394

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@zhijian-pro zhijian-pro force-pushed the clean_detached_node branch from 3514f7c to 2a5df47 Compare March 28, 2023 11:05
@zhijian-pro zhijian-pro marked this pull request as draft March 28, 2023 11:07
@zhijian-pro zhijian-pro force-pushed the clean_detached_node branch from 2a5df47 to 2458691 Compare March 28, 2023 11:26
@zhijian-pro zhijian-pro force-pushed the clean_detached_node branch from 2458691 to 96d87c5 Compare March 28, 2023 11:27
@github-actions
Copy link

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.32 failed:92, passed:44, compile error:40, out of coverage:31, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4541365188/jobs/8003478363

pkg/meta/base_test.go-2-4: score:0.24 failed:125, passed:40, compile error:18, out of coverage:25, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4541365188/jobs/8003478615

pkg/meta/base_test.go-4-4: score:0.52 failed:84, passed:91, compile error:16, out of coverage:13, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4541365188/jobs/8003479101

pkg/meta/base_test.go-3-4: score:0.38 failed:116, passed:71, compile error:12, out of coverage:9, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4541365188/jobs/8003478830

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@zhijian-pro zhijian-pro marked this pull request as ready for review March 28, 2023 11:52
@github-actions
Copy link

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.32 failed:92, passed:44, compile error:40, out of coverage:31, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4541441752/jobs/8003643190

pkg/meta/base_test.go-2-4: score:0.24 failed:125, passed:40, compile error:18, out of coverage:25, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4541441752/jobs/8003643451

pkg/meta/base_test.go-4-4: score:0.52 failed:84, passed:91, compile error:16, out of coverage:13, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4541441752/jobs/8003644024

pkg/meta/base_test.go-3-4: score:0.39 failed:114, passed:73, compile error:12, out of coverage:9, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4541441752/jobs/8003643733

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@github-actions
Copy link

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.32 failed:92, passed:44, compile error:40, out of coverage:31, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4541520217/jobs/8003824032

pkg/meta/base_test.go-2-4: score:0.24 failed:125, passed:40, compile error:18, out of coverage:25, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4541520217/jobs/8003824305

pkg/meta/base_test.go-4-4: score:0.52 failed:84, passed:91, compile error:16, out of coverage:13, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4541520217/jobs/8003824883

pkg/meta/base_test.go-3-4: score:0.39 failed:114, passed:73, compile error:12, out of coverage:9, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4541520217/jobs/8003824521

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@davies davies merged commit c159d9e into main Mar 28, 2023
@davies davies deleted the clean_detached_node branch March 28, 2023 12:29
@github-actions
Copy link

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.32 failed:92, passed:44, compile error:40, out of coverage:31, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4542329897/jobs/8005651984

pkg/meta/base_test.go-2-4: score:0.24 failed:125, passed:40, compile error:18, out of coverage:25, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4542329897/jobs/8005652199

pkg/meta/base_test.go-4-4: score:0.52 failed:84, passed:91, compile error:16, out of coverage:13, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4542329897/jobs/8005652567

pkg/meta/base_test.go-3-4: score:0.39 failed:114, passed:73, compile error:12, out of coverage:9, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4542329897/jobs/8005652373

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davies davies davies left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhijian-pro @codecov-commenter @davies