support parallel directory summary #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xixi <[email protected]>
Signed-off-by: xixi <[email protected]>
Signed-off-by: xixi <[email protected]>
Signed-off-by: xixi <[email protected]>
davies
reviewed
Mar 16, 2023
pkg/meta/utils.go
Outdated
| summary.Dirs++ | ||
| if recursive { | ||
| if st := fastGetSummary(r, ctx, e.Inode, summary, recursive); st != 0 { | ||
| const concurrency = 1000 |
There was a problem hiding this comment.
that's too high, may DOS the database, 20-50 should be enough.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3340 +/- ##
==========================================
+ Coverage 55.13% 55.20% +0.06%
==========================================
Files 142 142
Lines 34256 34286 +30
==========================================
+ Hits 18888 18926 +38
+ Misses 13369 13363 -6
+ Partials 1999 1997 -2
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: xixi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of strict summary and fast summary should run
readdirparallelly.Performance improvement
In engines that support high concurrency, such as TiKV, the parallel summary feature has become 20 times faster than before.