Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MultipartUpload test #3298

Closed
wants to merge 1 commit into from
Closed

fix MultipartUpload test #3298

wants to merge 1 commit into from

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Mar 7, 2023

For UFile: The size of all parts except the last part cannot be less than 4MB, otherwise calling the FinishMultipartUpload API will fail.

ref #3272

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (caefb53) 55.61% compared to head (6cb31e5) 55.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3298      +/-   ##
==========================================
+ Coverage   55.61%   55.66%   +0.04%     
==========================================
  Files         142      142              
  Lines       33825    33825              
==========================================
+ Hits        18812    18828      +16     
+ Misses      13019    13006      -13     
+ Partials     1994     1991       -3     
Impacted Files Coverage Δ
cmd/sync.go 50.34% <100.00%> (ø)
pkg/meta/redis.go 66.75% <0.00%> (+0.03%) ⬆️
pkg/chunk/cached_store.go 73.10% <0.00%> (+0.14%) ⬆️
pkg/chunk/disk_cache.go 73.54% <0.00%> (+0.29%) ⬆️
pkg/vfs/reader.go 79.90% <0.00%> (+0.63%) ⬆️
pkg/vfs/handle.go 84.32% <0.00%> (+0.74%) ⬆️
pkg/vfs/writer.go 78.65% <0.00%> (+1.16%) ⬆️
pkg/fuse/context.go 73.17% <0.00%> (+7.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Mutate Test Report
pkg/object/object_storage_test.go-1-1: score:0.17 failed:10, passed:2, compile error:1, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4350643566/jobs/7605744671

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@davies
Copy link
Contributor

davies commented Mar 7, 2023

Can we make sure that sync use correct part size for UFile?

// ufile: The size of all parts except the last part cannot be less than 4MB,
// otherwise it will cause the call to the FinishMultipartUpload API to fail.
if _, ok := s.(*withPrefix).os.(*ufile); ok {
part2Size = partSize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use MinPartSize

@zhijian-pro zhijian-pro marked this pull request as draft March 8, 2023 05:37
@zhijian-pro zhijian-pro closed this Mar 8, 2023
@zhijian-pro zhijian-pro deleted the fix_ufile_test branch May 15, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants