cmd/clone: add the clone subcommand #3279

zhijian-pro · 2023-03-01T13:01:57Z

Basic functionality is ok, but it hasn't been tested in detail.

github-actions · 2023-03-01T13:17:44Z

Mutate Test Report
cmd/clone_test.go-1-1: score:0.00 failed:26, passed:0, compile error:0, out of coverage:2, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4303796571/jobs/7503997180

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

codecov-commenter · 2023-03-01T13:26:41Z

Codecov Report

Patch coverage: 44.14% and project coverage change: -0.39 ⚠️

Comparison is base (b062694) 55.08% compared to head (7de3a3b) 54.69%.

❗ Current head 7de3a3b differs from pull request most recent head 748346e. Consider uploading reports for the commit 748346e to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3279      +/-   ##
==========================================
- Coverage   55.08%   54.69%   -0.39%     
==========================================
  Files         143      144       +1     
  Lines       34378    35341     +963     
==========================================
+ Hits        18936    19331     +395     
- Misses      13428    13907     +479     
- Partials     2014     2103      +89

Impacted Files	Coverage Δ
pkg/meta/interface.go	`51.42% <ø> (ø)`
pkg/utils/utils.go	`63.94% <0.00%> (-4.67%)`	⬇️
pkg/utils/utils_unix.go	`26.66% <0.00%> (-4.11%)`	⬇️
pkg/vfs/internal.go	`50.15% <25.00%> (-2.55%)`	⬇️
cmd/clone.go	`26.31% <26.31%> (ø)`
pkg/meta/sql.go	`57.32% <41.80%> (-2.18%)`	⬇️
pkg/meta/redis.go	`65.42% <48.01%> (-1.38%)`	⬇️
pkg/meta/tkv.go	`69.67% <51.28%> (-1.97%)`	⬇️
pkg/meta/utils.go	`54.48% <66.66%> (ø)`
cmd/main.go	`45.57% <100.00%> (+0.24%)`	⬆️
... and 1 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions · 2023-03-02T11:00:02Z

Mutate Test Report
cmd/clone_test.go-1-1: score:0.00 failed:26, passed:0, compile error:0, out of coverage:2, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4313158365/jobs/7524637619

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

2. add unit test 3. fix windows build

2. fix windows build

cmd/clone_unix.go

pkg/meta/redis.go

cmd/clone.go

pkg/meta/redis.go

github-actions · 2023-03-20T07:48:49Z

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.43 failed:59, passed:44, compile error:23, out of coverage:35, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4465269138/jobs/7842191926

pkg/meta/base_test.go-2-4: score:0.20 failed:97, passed:25, compile error:18, out of coverage:22, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4465269138/jobs/7842192025

pkg/meta/base_test.go-4-4: score:0.51 failed:67, passed:71, compile error:11, out of coverage:9, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4465269138/jobs/7842192202

pkg/meta/base_test.go-3-4: score:0.41 failed:85, passed:59, compile error:8, out of coverage:10, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4465269138/jobs/7842192110

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

github-actions · 2023-03-20T10:33:06Z

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.43 failed:59, passed:44, compile error:23, out of coverage:35, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4466336703/jobs/7844430430

pkg/meta/base_test.go-2-4: score:0.20 failed:97, passed:25, compile error:18, out of coverage:22, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4466336703/jobs/7844430642

pkg/meta/base_test.go-4-4: score:0.51 failed:67, passed:71, compile error:11, out of coverage:9, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4466336703/jobs/7844430976

pkg/meta/base_test.go-3-4: score:0.41 failed:85, passed:59, compile error:8, out of coverage:10, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4466336703/jobs/7844430817

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

github-actions · 2023-03-22T10:14:33Z

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.43 failed:59, passed:44, compile error:22, out of coverage:36, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4487927915/jobs/7891939550

pkg/meta/base_test.go-2-4: score:0.20 failed:100, passed:25, compile error:16, out of coverage:21, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4487927915/jobs/7891939697

pkg/meta/base_test.go-4-4: score:0.53 failed:65, passed:72, compile error:9, out of coverage:12, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4487927915/jobs/7891939995

pkg/meta/base_test.go-3-4: score:0.41 failed:85, passed:59, compile error:8, out of coverage:10, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4487927915/jobs/7891939841

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

github-actions · 2023-03-22T14:34:22Z

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.40 failed:67, passed:44, compile error:22, out of coverage:28, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4490121552/jobs/7896837026

pkg/meta/base_test.go-2-4: score:0.19 failed:106, passed:25, compile error:18, out of coverage:13, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4490121552/jobs/7896837318

pkg/meta/base_test.go-4-4: score:0.52 failed:66, passed:71, compile error:11, out of coverage:10, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4490121552/jobs/7896837759

pkg/meta/base_test.go-3-4: score:0.41 failed:86, passed:59, compile error:8, out of coverage:9, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4490121552/jobs/7896837532

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

github-actions · 2023-03-22T14:58:06Z

Mutate Test Report
pkg/meta/base_test.go-1-4: score:0.40 failed:67, passed:44, compile error:22, out of coverage:28, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/4490282471/jobs/7897194324

pkg/meta/base_test.go-2-4: score:0.19 failed:106, passed:25, compile error:18, out of coverage:13, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4490282471/jobs/7897194540

pkg/meta/base_test.go-4-4: score:0.51 failed:67, passed:70, compile error:11, out of coverage:10, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4490282471/jobs/7897194907

pkg/meta/base_test.go-3-4: score:0.41 failed:86, passed:59, compile error:8, out of coverage:9, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4490282471/jobs/7897194702

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

add clone cmd

796d529

support hardlink

5c7cbee

1. concurrent clone

8d8c478

2. add unit test 3. fix windows build

zhijian-pro force-pushed the add_clone_cmd branch from 4b03eb4 to 8d8c478 Compare March 5, 2023 11:08

fix windows build

eefca0e

zhijian-pro marked this pull request as ready for review March 6, 2023 02:27

zhijian-pro marked this pull request as draft March 6, 2023 02:28

1. fix redis cluster test

fa2929a

2. fix windows build

zhijian-pro force-pushed the add_clone_cmd branch from 4478272 to c331ef9 Compare March 6, 2023 08:03

fix windows build

dc70bc8

zhijian-pro force-pushed the add_clone_cmd branch from c331ef9 to dc70bc8 Compare March 6, 2023 08:06

zhijian-pro added 2 commits March 6, 2023 16:33

fix build

5738af2

add a progress bar display for the "clone" command

842dab8

zhijian-pro changed the title ~~add the clone subcommand~~ cmd/clone: add the clone subcommand Mar 6, 2023

fix windows build

1e0a0ac

zhijian-pro marked this pull request as ready for review March 6, 2023 10:10

zhijian-pro added 2 commits March 7, 2023 09:57

fix test

51250f2

use uniform errors

870d31f

zhijian-pro requested review from SandyXSD and Hexilee March 9, 2023 08:58

Hexilee reviewed Mar 9, 2023

View reviewed changes

zhijian-pro marked this pull request as draft March 10, 2023 01:37

fix dstParent nlink and improve test

e709993

zhijian-pro force-pushed the add_clone_cmd branch from a819fed to e709993 Compare March 10, 2023 07:41

zhijian-pro added 3 commits March 10, 2023 16:03

remove concurrent

f80051a

adjust flag

fc23e82

add concurrent

0d8c662

zhijian-pro added 4 commits March 18, 2023 12:56

Merge branch 'main' into add_clone_cmd

be532bd

merge main

5c8d085

fix

1b4569a

fix check quota and align4K space

2c48b25

zhijian-pro force-pushed the add_clone_cmd branch from 3a6f041 to 2c48b25 Compare March 20, 2023 03:24

zhijian-pro marked this pull request as ready for review March 20, 2023 03:47

del clone dstNode

8491103