flush dir stat in less transactions #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xixi <[email protected]>
Signed-off-by: xixi <[email protected]>
Signed-off-by: xixi <[email protected]>
Signed-off-by: xixi <[email protected]>
Signed-off-by: xixi <[email protected]>
Signed-off-by: xixi <[email protected]>
Signed-off-by: xixi <[email protected]>
Signed-off-by: xixi <[email protected]>
Hexilee
requested review from
SandyXSD and
davies
and removed request for
SandyXSD
davies
reviewed
Mar 2, 2023
davies
reviewed
Mar 2, 2023
pkg/meta/base.go
Outdated
| var eg errgroup.Group | ||
| for i, s := range stats { | ||
| ino, stat := i, s | ||
| eg.Go(func() error { |
There was a problem hiding this comment.
They are independent, so we should not cancel others if one of them fail
There was a problem hiding this comment.
Also, we cant to update the stats right after the calculation, don't wait for other large directories. So it's better to move the parallization out of calculation
davies
reviewed
Mar 2, 2023
pkg/meta/redis.go
Outdated
| for _, ino := range group { | ||
| field := strconv.FormatUint(uint64(ino), 10) | ||
| if stat, ok := nonexist[ino]; ok { | ||
| pipe.HSetNX(ctx, spaceKey, field, stat.space) |
davies
reviewed
Mar 2, 2023
davies
reviewed
Mar 2, 2023
Signed-off-by: xixi <[email protected]>
Signed-off-by: xixi <[email protected]>
Signed-off-by: xixi <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3277 +/- ##
==========================================
+ Coverage 55.55% 55.62% +0.07%
==========================================
Files 142 142
Lines 33741 33822 +81
==========================================
+ Hits 18746 18815 +69
- Misses 13013 13015 +2
- Partials 1982 1992 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: xixi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.