Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync env in juicefs cluster mode #3254

Merged
merged 3 commits into from
Feb 20, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions pkg/sync/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,22 @@ func launchWorker(address string, config *Config, wg *sync.WaitGroup) {
return
}
// launch itself
var args = []string{host, rpath}
var args = []string{host}
// set env
var printEnv []string
for k, v := range config.Env {
args = append(args, fmt.Sprintf("%s=%s", k, v))
zhijian-pro marked this conversation as resolved.
Show resolved Hide resolved
if strings.Contains(k, "SECRET") ||
strings.Contains(k, "TOKEN") ||
strings.Contains(k, "PASSWORD") ||
strings.Contains(k, "AZURE_STORAGE_CONNECTION_STRING") ||
strings.Contains(k, "JFS_RSA_PASSPHRASE") {
v = "******"
}
printEnv = append(printEnv, fmt.Sprintf("%s=%s", k, v))
}

args = append(args, rpath)
if strings.HasSuffix(path, "juicefs") {
args = append(args, os.Args[1:]...)
args = append(args, "--manager", address)
Expand All @@ -255,8 +270,12 @@ func launchWorker(address string, config *Config, wg *sync.WaitGroup) {
if !config.Verbose && !config.Quiet {
args = append(args, "-q")
}

logger.Debugf("launch worker command args: [ssh, %s]", strings.Join(args, ", "))
var argsBk = make([]string, len(args))
copy(argsBk, args)
for i, s := range printEnv {
argsBk[i+1] = s
}
logger.Debugf("launch worker command args: [ssh, %s]", strings.Join(argsBk, ", "))
cmd = exec.Command("ssh", args...)
stderr, err := cmd.StderrPipe()
if err != nil {
Expand Down
84 changes: 84 additions & 0 deletions pkg/sync/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
package sync

import (
"os"
"strings"

"github.com/urfave/cli/v2"
)

Expand Down Expand Up @@ -44,6 +47,72 @@ type Config struct {
Quiet bool
CheckAll bool
CheckNew bool
Env map[string]string
}

func envList() []string {
return []string{
"ACCESS_KEY",
"SECRET_KEY",
"SESSION_TOKEN",

"MINIO_ACCESS_KEY",
"MINIO_SECRET_KEY",
"MINIO_REGION",

"META_PASSWORD",
"REDIS_PASSWORD",
"SENTINEL_PASSWORD",
"SENTINEL_PASSWORD_FOR_OBJ",

"AZURE_STORAGE_CONNECTION_STRING",

"BDCLOUD_DEFAULT_REGION",
"BDCLOUD_ACCESS_KEY",
"BDCLOUD_SECRET_KEY",

"COS_SECRETID",
"COS_SECRETKEY",

"EOS_ACCESS_KEY",
"EOS_SECRET_KEY",
"EOS_TOKEN",

"GOOGLE_CLOUD_PROJECT",

"HADOOP_USER_NAME",
"HADOOP_SUPER_USER",
"HADOOP_SUPER_GROUP",
"KRB5_CONFIG",
"KRB5CCNAME",

"AWS_REGION",
"AWS_DEFAULT_REGION",

"HWCLOUD_DEFAULT_REGION",
"HWCLOUD_ACCESS_KEY",
"HWCLOUD_SECRET_KEY",

"ALICLOUD_REGION_ID",
"ALICLOUD_ACCESS_KEY_ID",
"ALICLOUD_ACCESS_KEY_SECRET",
"SECURITY_TOKEN",

"QINIU_DOMAIN",

"SCW_ACCESS_KEY",
"SCW_SECRET_KEY",

"SSH_PRIVATE_KEY_PATH",
"SSH_AUTH_SOCK",

"JFS_RSA_PASSPHRASE",
"PYROSCOPE_AUTH_TOKEN",
"DISPLAY_PROGRESSBAR",
"CGOFUSE_TRACE",
"JUICEFS_DEBUG",
"JUICEFS_LOGLEVEL",
}
}

func NewConfigFromCli(c *cli.Context) *Config {
Expand Down Expand Up @@ -74,10 +143,25 @@ func NewConfigFromCli(c *cli.Context) *Config {
Quiet: c.Bool("quiet"),
CheckAll: c.Bool("check-all"),
CheckNew: c.Bool("check-new"),
Env: make(map[string]string),
}
if cfg.Threads <= 0 {
logger.Warnf("threads should be larger than 0, reset it to 1")
cfg.Threads = 1
}

for _, key := range envList() {
if os.Getenv(key) != "" {
cfg.Env[key] = os.Getenv(key)
}
}
// pass all the variable that contains "JFS"
for _, ekv := range os.Environ() {
key := strings.Split(ekv, "=")[0]
if strings.Contains(key, "JFS") {
cfg.Env[key] = os.Getenv(key)
}
}

return cfg
}