Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umount: wait for writting staging chunks #3224

Merged
merged 7 commits into from
Feb 10, 2023
Merged

Conversation

Hexilee
Copy link
Contributor

@Hexilee Hexilee commented Feb 9, 2023

Signed-off-by: xixi [email protected]

close #2644

Example

hexi@ArchLinux ~/s/juicefs (main)> sudo ./juicefs umount ~/mnt/jfs/
6.6 GiB staging chunks are being written back... 126 MiB/s, left 53s

@Hexilee Hexilee marked this pull request as ready for review February 9, 2023 06:33
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Base: 55.68% // Head: 55.57% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (6832a60) compared to base (c8ea744).
Patch coverage: 6.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3224      +/-   ##
==========================================
- Coverage   55.68%   55.57%   -0.12%     
==========================================
  Files         142      142              
  Lines       33056    33140      +84     
==========================================
+ Hits        18408    18417       +9     
- Misses      12706    12779      +73     
- Partials     1942     1944       +2     
Impacted Files Coverage Δ
cmd/umount.go 26.51% <6.66%> (-27.73%) ⬇️
pkg/vfs/fill.go 65.21% <0.00%> (-2.46%) ⬇️
pkg/chunk/cached_store.go 72.77% <0.00%> (-0.14%) ⬇️
pkg/meta/tkv.go 70.82% <0.00%> (-0.13%) ⬇️
pkg/chunk/disk_cache.go 73.38% <0.00%> (ø)
pkg/meta/sql.go 59.06% <0.00%> (+0.14%) ⬆️
pkg/utils/progress.go 76.27% <0.00%> (+1.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Hexilee Hexilee requested a review from davies February 9, 2023 07:18
cmd/umount.go Outdated Show resolved Hide resolved
cmd/umount.go Outdated Show resolved Hide resolved
cmd/umount.go Outdated Show resolved Hide resolved
cmd/umount.go Outdated Show resolved Hide resolved
@Hexilee Hexilee requested a review from davies February 10, 2023 02:09
@davies davies merged commit 018b8a9 into main Feb 10, 2023
@davies davies deleted the umount-until-writeback branch February 10, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wait completion of staging blocks in writeback mode
4 participants