Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/mount: reset output for 'log' package in daemon mode #3206

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Jan 31, 2023

This fixes the issue that on some linux releases (e.g. Ubuntu 20.04), the go-fuse log is not printed in the juicefs.log file when running in daemon mode with -o debug.

The user reporting this issue also mentioned that the log is normal when testing on MacOS (confirmed) and early linux (kernel v.2.6).

@codecov-commenter
Copy link

Codecov Report

Base: 55.70% // Head: 55.68% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (4f1fad3) compared to base (fcedbee).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3206      +/-   ##
==========================================
- Coverage   55.70%   55.68%   -0.03%     
==========================================
  Files         142      142              
  Lines       33045    33048       +3     
==========================================
- Hits        18407    18402       -5     
- Misses      12699    12704       +5     
- Partials     1939     1942       +3     
Impacted Files Coverage Δ
cmd/mount.go 55.01% <0.00%> (-0.34%) ⬇️
pkg/meta/tkv_mem.go 92.44% <0.00%> (-1.17%) ⬇️
pkg/meta/tkv.go 70.82% <0.00%> (-0.42%) ⬇️
pkg/meta/redis.go 66.38% <0.00%> (+0.03%) ⬆️
pkg/chunk/disk_cache.go 73.38% <0.00%> (+0.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davies davies merged commit f2fd749 into main Jan 31, 2023
@davies davies deleted the daemon-log branch January 31, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants