Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warmup metadata when open cache enabled #3185

Merged
merged 3 commits into from
Feb 8, 2023
Merged

warmup metadata when open cache enabled #3185

merged 3 commits into from
Feb 8, 2023

Conversation

Hexilee
Copy link
Contributor

@Hexilee Hexilee commented Jan 13, 2023

Signed-off-by: xixi [email protected]

close #2992

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Base: 55.71% // Head: 55.60% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (260d059) compared to base (55b0ebc).
Patch coverage: 72.22% of modified lines in pull request are covered.

❗ Current head 260d059 differs from pull request most recent head 626117e. Consider uploading reports for the commit 626117e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3185      +/-   ##
==========================================
- Coverage   55.71%   55.60%   -0.11%     
==========================================
  Files         142      142              
  Lines       33016    33061      +45     
==========================================
- Hits        18395    18385      -10     
- Misses      12681    12731      +50     
- Partials     1940     1945       +5     
Impacted Files Coverage Δ
pkg/vfs/fill.go 65.21% <0.00%> (-2.46%) ⬇️
cmd/warmup.go 34.10% <100.00%> (ø)
pkg/fs/fs.go 73.29% <0.00%> (-1.65%) ⬇️
cmd/mount.go 55.01% <0.00%> (-0.34%) ⬇️
cmd/debug.go 14.09% <0.00%> (-0.32%) ⬇️
pkg/meta/base.go 63.57% <0.00%> (-0.21%) ⬇️
pkg/meta/tkv.go 70.82% <0.00%> (-0.21%) ⬇️
pkg/meta/redis.go 66.28% <0.00%> (-0.21%) ⬇️
pkg/meta/sql.go 58.92% <0.00%> (-0.11%) ⬇️
pkg/meta/interface.go 49.00% <0.00%> (+0.40%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Mutate Test Report
pkg/vfs/fill_test.go-1-1: score:0.20 failed:48, passed:12, compile error:6, out of coverage:3, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3927019537/jobs/6713269463

pkg/meta/base_test.go-4-4: score:0.50 failed:63, passed:63, compile error:11, out of coverage:6, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3927019537/jobs/6713269419

pkg/meta/base_test.go-1-4: score:0.34 failed:71, passed:36, compile error:21, out of coverage:16, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/3927019537/jobs/6713269281

pkg/meta/base_test.go-2-4: score:0.21 failed:89, passed:23, compile error:17, out of coverage:16, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3927019537/jobs/6713269341

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@Hexilee Hexilee marked this pull request as ready for review January 16, 2023 16:05
@github-actions
Copy link

Mutate Test Report
pkg/vfs/fill_test.go-1-1: score:0.20 failed:48, passed:12, compile error:6, out of coverage:3, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3927019537/jobs/6713269463

pkg/meta/base_test.go-4-4: score:0.50 failed:63, passed:63, compile error:11, out of coverage:6, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3927019537/jobs/6713269419

pkg/meta/base_test.go-1-4: score:0.34 failed:71, passed:36, compile error:21, out of coverage:16, skip by comment:0, others:1
Job detail: https://github.com/juicedata/juicefs/actions/runs/3927019537/jobs/6713269281

pkg/meta/base_test.go-2-4: score:0.21 failed:89, passed:23, compile error:17, out of coverage:16, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3927019537/jobs/6713269341

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@Hexilee Hexilee changed the title warmup metadata when asked warmup metadata when enable open cache Feb 8, 2023
@Hexilee Hexilee requested review from SandyXSD and davies February 8, 2023 09:17
@Hexilee Hexilee changed the title warmup metadata when enable open cache warmup metadata when open cache enabled Feb 8, 2023
@davies davies merged commit 035cec1 into main Feb 8, 2023
@davies davies deleted the warmup-metadata branch February 8, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warmup metadata when asked
3 participants