Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: rename DeletedSlice to TrashSlice and DeletedFile to PendingDeletedFile #3085

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

Hexilee
Copy link
Contributor

@Hexilee Hexilee commented Dec 14, 2022

Signed-off-by: xixi [email protected]

In current implementation, delfile means files that were deleted delayed and could be cleaned immediately, while the delslice means slices that were swept into trash and should be cleaned according to trash-days.

In this PR, we renamed them more appropriately.

@Hexilee Hexilee requested a review from davies December 14, 2022 08:05
@Hexilee Hexilee changed the title status: rename DeletedSlice to TrashSlice status: rename DeletedSlice to TrashSlice and DeletedFile to DelayedDeletedFile Dec 14, 2022
cmd/status.go Outdated Show resolved Hide resolved
@Hexilee Hexilee changed the title status: rename DeletedSlice to TrashSlice and DeletedFile to DelayedDeletedFile status: rename DeletedSlice to TrashSlice and DeletedFile to PendingDeletedFile Dec 14, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 58.34% // Head: 58.41% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (0816319) compared to base (51fe48d).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 0816319 differs from pull request most recent head 7ade376. Consider uploading reports for the commit 7ade376 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3085      +/-   ##
==========================================
+ Coverage   58.34%   58.41%   +0.06%     
==========================================
  Files         141      141              
  Lines       25076    25076              
==========================================
+ Hits        14630    14647      +17     
+ Misses       8502     8490      -12     
+ Partials     1944     1939       -5     
Impacted Files Coverage Δ
cmd/status.go 53.62% <0.00%> (ø)
pkg/chunk/prefetch.go 94.11% <0.00%> (-5.89%) ⬇️
pkg/chunk/disk_cache.go 73.95% <0.00%> (-1.40%) ⬇️
pkg/chunk/cached_store.go 73.89% <0.00%> (-0.92%) ⬇️
pkg/vfs/handle.go 85.56% <0.00%> (ø)
pkg/meta/tkv.go 73.30% <0.00%> (+0.11%) ⬆️
pkg/meta/sql.go 62.08% <0.00%> (+0.37%) ⬆️
pkg/meta/tkv_mem.go 87.50% <0.00%> (+0.69%) ⬆️
pkg/meta/tkv_etcd.go 72.63% <0.00%> (+1.05%) ⬆️
pkg/vfs/reader.go 79.20% <0.00%> (+3.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davies davies merged commit a35fe21 into main Dec 14, 2022
@davies davies deleted the rename-delelted-slices branch December 14, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants