Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix config equal when checking re-mount #3059

Merged
merged 2 commits into from
Dec 6, 2022
Merged

fix config equal when checking re-mount #3059

merged 2 commits into from
Dec 6, 2022

Conversation

Hexilee
Copy link
Contributor

@Hexilee Hexilee commented Dec 6, 2022

Signed-off-by: xixi [email protected]

close #3053

@Hexilee Hexilee requested a review from SandyXSD December 6, 2022 08:48
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Base: 58.24% // Head: 58.29% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (6004737) compared to base (5b3de35).
Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3059      +/-   ##
==========================================
+ Coverage   58.24%   58.29%   +0.04%     
==========================================
  Files         141      141              
  Lines       25051    25066      +15     
==========================================
+ Hits        14591    14611      +20     
+ Misses       8515     8510       -5     
  Partials     1945     1945              
Impacted Files Coverage Δ
cmd/mount.go 57.69% <77.77%> (+2.39%) ⬆️
pkg/fuse/context.go 64.28% <0.00%> (-10.72%) ⬇️
pkg/vfs/handle.go 85.56% <0.00%> (ø)
pkg/vfs/reader.go 75.84% <0.00%> (ø)
pkg/meta/sql.go 61.94% <0.00%> (+0.23%) ⬆️
pkg/meta/tkv_mem.go 87.50% <0.00%> (+0.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Mutate Test Report
cmd/mount_test.go-4-4: score:1.00 failed:0, passed:48, compile error:5, out of coverage:1, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3628253489/jobs/6119078967

cmd/mount_test.go-1-4: score:1.00 failed:0, passed:46, compile error:10, out of coverage:1, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3628253489/jobs/6119078519

cmd/mount_test.go-2-4: score:1.00 failed:0, passed:51, compile error:2, out of coverage:4, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3628253489/jobs/6119078696

cmd/mount_test.go-3-4: score:1.00 failed:0, passed:55, compile error:2, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3628253489/jobs/6119436962

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@Hexilee Hexilee merged commit ae49307 into main Dec 6, 2022
@Hexilee Hexilee deleted the fix-config-equal branch December 6, 2022 11:52
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Mutate Test Report
cmd/mount_test.go-1-4: score:1.00 failed:0, passed:44, compile error:9, out of coverage:1, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3627927830/jobs/6118374138

cmd/mount_test.go-3-4: score:1.00 failed:0, passed:52, compile error:2, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3627927830/jobs/6118374362

cmd/mount_test.go-2-4: score:1.00 failed:0, passed:48, compile error:2, out of coverage:4, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3627927830/jobs/6118374278

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when dir is already mounted by juicefs enterprise
3 participants