Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: remove meta password #3003

Merged
merged 1 commit into from
Nov 21, 2022
Merged

meta: remove meta password #3003

merged 1 commit into from
Nov 21, 2022

Conversation

zhijian-pro
Copy link
Contributor

close #3002

@zhijian-pro zhijian-pro requested a review from SandyXSD November 21, 2022 06:34
@codecov-commenter
Copy link

Codecov Report

Base: 58.81% // Head: 58.65% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (417da07) compared to base (56f2f44).
Patch coverage: 29.10% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3003      +/-   ##
==========================================
- Coverage   58.81%   58.65%   -0.16%     
==========================================
  Files         141      141              
  Lines       24613    24723     +110     
==========================================
+ Hits        14476    14502      +26     
- Misses       8254     8333      +79     
- Partials     1883     1888       +5     
Impacted Files Coverage Δ
pkg/meta/base.go 66.75% <0.00%> (-0.90%) ⬇️
pkg/meta/interface.go 45.45% <0.00%> (ø)
pkg/meta/sql.go 63.35% <16.66%> (-0.58%) ⬇️
pkg/meta/redis.go 69.01% <22.22%> (-0.79%) ⬇️
pkg/meta/tkv.go 74.69% <27.27%> (+0.25%) ⬆️
cmd/status.go 52.85% <30.00%> (-17.88%) ⬇️
pkg/meta/sql_lock.go 71.72% <100.00%> (+1.43%) ⬆️
pkg/vfs/reader.go 75.42% <0.00%> (-3.58%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhijian-pro zhijian-pro merged commit 3b2e331 into main Nov 21, 2022
@zhijian-pro zhijian-pro deleted the fix_remove_pwd branch November 21, 2022 07:01
SandyXSD pushed a commit that referenced this pull request Dec 15, 2022
@SandyXSD SandyXSD mentioned this pull request Dec 16, 2022
SandyXSD pushed a commit that referenced this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

password is exposed when mysql database is not available
3 participants