Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount: ignore command when mount point is already mounted by the same juicefs #2979

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

Hexilee
Copy link
Contributor

@Hexilee Hexilee commented Nov 14, 2022

Signed-off-by: xixi [email protected]

Close #2840

  • Ignore mount when the mount point is already mounted by the same juicefs
  • Add force flag for the mount subcommand to mount the same mount point forcibly

@@ -140,6 +140,11 @@ func mount_flags() []cli.Flag {
Name: "enable-ioctl",
Usage: "enable ioctl (support GETFLAGS/SETFLAGS only)",
},
&cli.BoolFlag{
Name: "f",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f was used as --foreground, so don't use it as --force, remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@codecov-commenter
Copy link

Codecov Report

Base: 58.90% // Head: 58.90% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (2279d46) compared to base (3775055).
Patch coverage: 43.33% of modified lines in pull request are covered.

❗ Current head 2279d46 differs from pull request most recent head fd40705. Consider uploading reports for the commit fd40705 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2979      +/-   ##
==========================================
- Coverage   58.90%   58.90%   -0.01%     
==========================================
  Files         141      141              
  Lines       24565    24594      +29     
==========================================
+ Hits        14471    14488      +17     
- Misses       8218     8229      +11     
- Partials     1876     1877       +1     
Impacted Files Coverage Δ
cmd/mount.go 58.09% <32.00%> (-2.46%) ⬇️
cmd/mount_unix.go 51.28% <100.00%> (+2.17%) ⬆️
pkg/vfs/writer.go 76.58% <0.00%> (-1.20%) ⬇️
pkg/chunk/disk_cache.go 74.15% <0.00%> (-0.80%) ⬇️
pkg/meta/redis.go 69.79% <0.00%> (+0.04%) ⬆️
pkg/meta/sql.go 64.07% <0.00%> (+0.09%) ⬆️
cmd/flags.go 94.11% <0.00%> (+0.14%) ⬆️
pkg/meta/tkv.go 74.88% <0.00%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davies davies merged commit 8a7c0e5 into main Nov 14, 2022
@davies davies deleted the avoid-repeated-mount branch November 14, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple mount on the same mount point
3 participants