Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta/fdb: fix scan for many keys #2824

Merged
merged 1 commit into from
Sep 30, 2022
Merged

meta/fdb: fix scan for many keys #2824

merged 1 commit into from
Sep 30, 2022

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Sep 29, 2022

close #2801

The read transaction for scanning is retried, which leads to the huge number of scanned keys. In fdb, there is a 5s limit for the read transaction.

refs: https://forums.foundationdb.org/t/large-range-scans-avoid-5s-limit/292

@codecov-commenter
Copy link

Codecov Report

Base: 59.32% // Head: 59.33% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (504c2d1) compared to base (953a763).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2824   +/-   ##
=======================================
  Coverage   59.32%   59.33%           
=======================================
  Files         140      140           
  Lines       24310    24324   +14     
=======================================
+ Hits        14423    14433   +10     
- Misses       8035     8038    +3     
- Partials     1852     1853    +1     
Impacted Files Coverage Δ
pkg/meta/tkv_fdb.go 85.05% <83.33%> (-2.62%) ⬇️
pkg/meta/tkv_mem.go 86.61% <0.00%> (-0.71%) ⬇️
pkg/meta/sql.go 64.45% <0.00%> (-0.20%) ⬇️
pkg/meta/tkv.go 75.14% <0.00%> (+0.11%) ⬆️
pkg/vfs/writer.go 77.77% <0.00%> (+1.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davies davies merged commit 55f6ff4 into main Sep 30, 2022
@davies davies deleted the fdb-scan branch September 30, 2022 00:33
@T-TRz879
Copy link
Contributor

I saw on the official website about the transaction solution that needs to run for a long time Long-running transactions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dump scan keys error on foundationdb meta engine
4 participants