Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List with delimiter #2813

Merged
merged 18 commits into from
Sep 29, 2022
Merged

List with delimiter #2813

merged 18 commits into from
Sep 29, 2022

Conversation

davies
Copy link
Contributor

@davies davies commented Sep 27, 2022

No description provided.

@davies davies requested a review from zhijian-pro September 27, 2022 05:39
# Conflicts:
#	pkg/object/object_storage_test.go
@zhijian-pro zhijian-pro marked this pull request as draft September 27, 2022 08:01
@zhijian-pro
Copy link
Contributor

zhijian-pro commented Sep 27, 2022

the storage of support list with delimiter:

  • S3
  • OSS
  • BOS
  • COS
  • Google cloud storage
  • B2
  • EOS
  • ks3
  • minio
  • obs
  • QingStor
  • scw
  • swift

@zhijian-pro zhijian-pro self-assigned this Sep 27, 2022
@zhijian-pro zhijian-pro marked this pull request as ready for review September 28, 2022 09:58
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Base: 59.37% // Head: 59.34% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (b282a13) compared to base (967e118).
Patch coverage: 19.13% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2813      +/-   ##
==========================================
- Coverage   59.37%   59.34%   -0.03%     
==========================================
  Files         140      140              
  Lines       24236    24310      +74     
==========================================
+ Hits        14389    14427      +38     
- Misses       7985     8033      +48     
+ Partials     1862     1850      -12     
Impacted Files Coverage Δ
pkg/object/azure.go 1.02% <0.00%> (-0.03%) ⬇️
pkg/object/b2.go 1.17% <0.00%> (ø)
pkg/object/bos.go 0.85% <0.00%> (-0.03%) ⬇️
pkg/object/cos.go 0.78% <0.00%> (-0.03%) ⬇️
pkg/object/etcd.go 1.09% <0.00%> (-0.03%) ⬇️
pkg/object/file.go 65.76% <ø> (ø)
pkg/object/gs.go 1.14% <0.00%> (-0.08%) ⬇️
pkg/object/hdfs.go 66.13% <ø> (+2.64%) ⬆️
pkg/object/ibmcos.go 0.70% <0.00%> (-0.03%) ⬇️
pkg/object/interface.go 80.00% <ø> (ø)
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
13.0% 13.0% Duplication

@davies davies merged commit 953a763 into main Sep 29, 2022
@davies davies deleted the list_with_delimiter branch September 29, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants