add upload delay metrics #2713
Merged
add upload delay metrics #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
davies
approved these changes
Sep 9, 2022
qingyunha
reviewed
Sep 9, 2022
| stageBlockDelay: prometheus.NewCounter(prometheus.CounterOpts{ | ||
| Name: "staging_block_delay_seconds", | ||
| Help: "Total seconds of delay for staging blocks", | ||
| }), |
There was a problem hiding this comment.
Should this metric be a histogram?
There was a problem hiding this comment.
A histogram can provide more information with more metrics, but a counter may be enough here (less metrics).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2614