Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/dump: add keep-secret-key option #2699

Merged
merged 1 commit into from
Sep 8, 2022
Merged

cmd/dump: add keep-secret-key option #2699

merged 1 commit into from
Sep 8, 2022

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Sep 8, 2022

close #2670

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #2699 (af4f73b) into main (4963abd) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #2699   +/-   ##
=======================================
  Coverage   59.55%   59.56%           
=======================================
  Files         138      138           
  Lines       23619    23623    +4     
=======================================
+ Hits        14067    14071    +4     
- Misses       7718     7719    +1     
+ Partials     1834     1833    -1     
Impacted Files Coverage Δ
pkg/meta/interface.go 45.39% <ø> (ø)
pkg/meta/redis.go 69.87% <50.00%> (+0.04%) ⬆️
pkg/meta/sql.go 63.71% <50.00%> (ø)
pkg/meta/tkv.go 74.51% <50.00%> (ø)
cmd/dump.go 79.06% <80.00%> (+2.14%) ⬆️
pkg/vfs/backup.go 61.11% <100.00%> (ø)
pkg/fs/fs.go 75.73% <0.00%> (-0.85%) ⬇️
pkg/chunk/disk_cache.go 78.69% <0.00%> (+0.48%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@davies davies merged commit f0ea0eb into main Sep 8, 2022
@davies davies deleted the dump-keep branch September 8, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a --keep-secret-key on dump command
3 participants