Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/mount: add cache-scan-interval option #2692

Merged
merged 2 commits into from
Sep 8, 2022
Merged

cmd/mount: add cache-scan-interval option #2692

merged 2 commits into from
Sep 8, 2022

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Sep 8, 2022 •
edited
Loading

related to #2688

@SandyXSD SandyXSD requested a review from davies September 8, 2022 02:40
@SandyXSD
Copy link
Contributor Author

SandyXSD commented Sep 8, 2022

@davies Most lines are changed by the gofmt.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022 •
edited
Loading

Codecov Report

Merging #2692 (fe438fd) into main (eca9f9b) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2692      +/-   ##
==========================================
+ Coverage   59.54%   59.62%   +0.07%     
==========================================
  Files         138      138              
  Lines       23610    23619       +9     
==========================================
+ Hits        14058    14082      +24     
+ Misses       7719     7708      -11     
+ Partials     1833     1829       -4
Impacted Files Coverage Δ
pkg/chunk/cached_store.go 77.15% <ø> (+1.34%) ⬆️
cmd/flags.go 93.81% <100.00%> (+0.16%) ⬆️
cmd/mount.go 59.28% <100.00%> (+0.12%) ⬆️
pkg/chunk/disk_cache.go 78.20% <100.00%> (+0.15%) ⬆️
pkg/vfs/writer.go 76.89% <0.00%> (-0.80%) ⬇️
pkg/meta/sql.go 64.00% <0.00%> (+0.19%) ⬆️
pkg/fs/fs.go 76.57% <0.00%> (+0.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SandyXSD SandyXSD requested a review from davies September 8, 2022 04:03
@davies davies merged commit 46bf918 into main Sep 8, 2022
@davies davies deleted the cache-scan-interval branch September 8, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davies davies Awaiting requested review from davies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SandyXSD @codecov-commenter @davies