Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunk: add checksum for cache files #2626

Merged
merged 12 commits into from
Sep 9, 2022
Merged

chunk: add checksum for cache files #2626

merged 12 commits into from
Sep 9, 2022

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Aug 29, 2022

No description provided.

@SandyXSD SandyXSD marked this pull request as ready for review September 7, 2022 02:20
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #2626 (c0508c6) into main (cdccfe8) will decrease coverage by 0.10%.
The diff coverage is 79.16%.

@@            Coverage Diff             @@
##             main    #2626      +/-   ##
==========================================
- Coverage   59.58%   59.48%   -0.11%     
==========================================
  Files         138      138              
  Lines       23626    23718      +92     
==========================================
+ Hits        14077    14108      +31     
- Misses       7716     7770      +54     
- Partials     1833     1840       +7     
Impacted Files Coverage Δ
pkg/chunk/cached_store.go 73.61% <50.00%> (-0.60%) ⬇️
pkg/chunk/disk_cache.go 75.00% <79.76%> (-3.21%) ⬇️
cmd/flags.go 93.96% <100.00%> (+0.15%) ⬆️
cmd/mount.go 60.49% <100.00%> (+0.12%) ⬆️
pkg/chunk/mem_cache.go 62.50% <0.00%> (-23.62%) ⬇️
pkg/vfs/reader.go 74.78% <0.00%> (-3.58%) ⬇️
pkg/meta/sql.go 63.95% <0.00%> (ø)
pkg/fs/fs.go 76.57% <0.00%> (+0.84%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@SandyXSD SandyXSD requested a review from davies September 7, 2022 04:55
cmd/flags.go Outdated Show resolved Hide resolved
cmd/flags.go Outdated Show resolved Hide resolved
pkg/chunk/disk_cache.go Outdated Show resolved Hide resolved
@SandyXSD SandyXSD requested a review from davies September 8, 2022 10:43
pkg/chunk/disk_cache.go Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@davies davies merged commit e571512 into main Sep 9, 2022
@davies davies deleted the wip-checksum branch September 9, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants