Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suport foundationdb for meta engine #2581

Merged
merged 10 commits into from
Sep 21, 2022
Merged

suport foundationdb for meta engine #2581

merged 10 commits into from
Sep 21, 2022

Conversation

Vigor-jpg
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SandyXSD SandyXSD mentioned this pull request Aug 24, 2022
Closed
5 tasks
SandyXSD
SandyXSD reviewed Aug 25, 2022
View reviewed changes
.github/workflows/unittests.yml Outdated Show resolved Hide resolved
pkg/meta/tkv_fdb.go Outdated Show resolved Hide resolved
pkg/meta/tkv_fdb.go Outdated Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Aug 26, 2022
View reviewed changes
pkg/meta/tkv_fdb.go Outdated Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Aug 26, 2022
View reviewed changes
pkg/meta/tkv_fdb.go Outdated Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Aug 26, 2022
View reviewed changes
pkg/meta/tkv_fdb.go Outdated Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Aug 26, 2022
View reviewed changes
pkg/meta/tkv_fdb.go Outdated Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Aug 26, 2022
View reviewed changes
pkg/meta/tkv_fdb.go Outdated Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Aug 26, 2022
View reviewed changes
pkg/meta/tkv_fdb.go Outdated Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Aug 26, 2022
View reviewed changes
pkg/meta/tkv_fdb.go Outdated Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Aug 26, 2022
View reviewed changes
pkg/meta/tkv_fdb.go Outdated Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Aug 26, 2022
View reviewed changes
pkg/meta/tkv_fdb.go Outdated Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Aug 26, 2022
View reviewed changes
pkg/meta/tkv_fdb.go Outdated Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Aug 26, 2022
View reviewed changes
pkg/meta/tkv_fdb.go Outdated Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Aug 26, 2022
View reviewed changes
pkg/meta/tkv_fdb.go Outdated Show resolved Hide resolved
@Vigor-jpg Vigor-jpg force-pushed the main branch 3 times, most recently from 5f330fc to 045999e Compare August 28, 2022 18:15
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2022 •
edited
Loading

Codecov Report

Merging #2581 (50e4b74) into main (391a730) will increase coverage by 0.06%.
The diff coverage is 77.33%.

❗ Current head 50e4b74 differs from pull request most recent head ee6df24. Consider uploading reports for the commit ee6df24 to get more accurate results

@@            Coverage Diff             @@
##             main    #2581      +/-   ##
==========================================
+ Coverage   59.71%   59.77%   +0.06%     
==========================================
  Files         138      139       +1     
  Lines       23750    23815      +65     
==========================================
+ Hits        14182    14236      +54     
- Misses       7721     7732      +11     
  Partials     1847     1847
Impacted Files Coverage Δ
pkg/meta/tkv_fdb.go 77.33% <77.33%> (ø)
pkg/vfs/writer.go 76.58% <0.00%> (-1.20%) ⬇️
pkg/fs/fs.go 75.73% <0.00%> (-0.85%) ⬇️
pkg/fuse/fuse.go 79.56% <0.00%> (-0.15%) ⬇️
pkg/meta/tkv.go 74.51% <0.00%> (-0.12%) ⬇️
pkg/meta/redis.go 70.00% <0.00%> (-0.05%) ⬇️
pkg/vfs/vfs.go 76.76% <0.00%> (ø)
pkg/meta/sql.go 63.85% <0.00%> (+0.09%) ⬆️
pkg/vfs/internal.go 58.91% <0.00%> (+0.40%) ⬆️
cmd/sync.go 56.46% <0.00%> (+1.19%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SandyXSD SandyXSD requested a review from davies September 21, 2022 02:07
@SandyXSD SandyXSD merged commit 682ff5e into juicedata:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losfair losfair losfair left review comments

@SandyXSD SandyXSD SandyXSD approved these changes

@davies davies Awaiting requested review from davies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vigor-jpg @CLAassistant @codecov-commenter @losfair @SandyXSD