fuse,meta: support GETFLAGS/SETFLAGS ioctl

[qingyunha]

No description provided.

[qingyunha]

close #775

Hi, I have a init implement for support ioctl. It's not complete and I hope your help, see if this is the right direction

[codecov-commenter]

Codecov Report

Merging #2346 (2830ebc) into main (e1c8d6a) will decrease coverage by 0.01%.
The diff coverage is 43.05%.

@@            Coverage Diff             @@
##             main    #2346      +/-   ##
==========================================
- Coverage   59.69%   59.68%   -0.02%     
==========================================
  Files         138      138              
  Lines       23341    23481     +140     
==========================================
+ Hits        13933    14014      +81     
- Misses       7596     7643      +47     
- Partials     1812     1824      +12     

Impacted Files	Coverage Δ
pkg/fuse/fuse.go	76.64% <0.00%> (-1.14%)	⬇️
pkg/meta/interface.go	46.80% <ø> (ø)
pkg/vfs/vfs_unix.go	76.23% <0.00%> (-21.47%)	⬇️
pkg/meta/sql.go	64.29% <64.28%> (+0.13%)	⬆️
pkg/utils/buffer.go	91.48% <66.66%> (ø)
pkg/meta/redis.go	70.14% <68.00%> (+0.15%)	⬆️
pkg/meta/tkv.go	74.90% <70.37%> (+0.10%)	⬆️
pkg/meta/base.go	68.80% <75.00%> (+0.39%)	⬆️
pkg/meta/tkv_mem.go	86.61% <0.00%> (-0.71%)	⬇️
pkg/chunk/disk_cache.go	79.20% <0.00%> (-0.50%)	⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[davies]

@qingyunha This looks pretty good, some details could be tuned.

[zhijian-pro]

doMknod should check parent dir's flags.

if (pattr.Flags & FlagImmutable) != 0 {
    return syscall.EPERM
}

[zhijian-pro]

doRename should check flags

if (sattr.Flags&FlagAppend) != 0 || (sattr.Flags&FlagImmutable) != 0 || (dattr.Flags&FlagImmutable) != 0 || (iattr.Flags&FlagAppend) != 0 || (iattr.Flags&FlagImmutable) != 0 {
	return syscall.EPERM
}

[SandyXSD]

@qingyunha Do you have time to continue this PR? If not, we can take is over.

[qingyunha]

Sorry for the delay. I still want to try to implement this feature, perhaps this weekend.

[SandyXSD]

Sure

[qingyunha]

Updated.

[SandyXSD]

Suggested change

	out.Result = int32(fs.v.Ioctl(ctx, Ino(in.NodeId), in.Cmd, in.Arg, bufIn, bufOut))
	return fuse.Status(fs.v.Ioctl(ctx, Ino(in.NodeId), in.Cmd, in.Arg, bufIn, bufOut))

[qingyunha]

I think the ioctl result should be set to out.Result. The return error will be the fuse protocol level error.

[SandyXSD]

@qingyunha Please rebase the PR and resolve the conflicts.

[SandyXSD]

Failed test:

 base_test.go:1570: fallocate f : operation not permitted

[qingyunha]

Failed test:

 base_test.go:1570: fallocate f : operation not permitted

Done.